You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/11/11 20:41:26 UTC

[GitHub] brodybits commented on a change in pull request #539: Fix dest overwrite

brodybits commented on a change in pull request #539: Fix dest overwrite
URL: https://github.com/apache/cordova-android/pull/539#discussion_r232503550
 
 

 ##########
 File path: bin/templates/cordova/lib/pluginHandlers.js
 ##########
 @@ -34,7 +34,7 @@ var handlers = {
             // a later plugins release.  This is for legacy plugins to work with Cordova.
 
             if (options && options.android_studio === true) {
-                dest = studioPathRemap(obj);
+                dest = studioPathRemap(obj) || dest;
 
 Review comment:
   It is not possible to cherry-pick or rebase this change to work on master. This change will be clobbered by another solution that works more easily on master.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org