[GitHub] Ben-Zvi commented on a change in pull request #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides

[GitBox <gi...@apache.org>]

Ben-Zvi commented on a change in pull request #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides
URL: https://github.com/apache/drill/pull/1373#discussion_r201531287
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
 ##########
 @@ -258,6 +251,13 @@ protected boolean prefetchFirstBatchFromBothSides() {
       return false;
 
 Review comment:
   The case of only one side receiving NONE is legit -- for those RIGHT/LEFT/FULL OUTER joins, where the other side is still returned.
   As for the update() on a NONE -- probably any setting of NONE also initializes the container's record count to zero.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services