You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by tellison <gi...@git.apache.org> on 2016/08/22 16:02:45 UTC
[GitHub] incubator-pirk pull request #75: Enhancements to parallelism of query encryp...
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/75
Enhancements to parallelism of query encryption.
- Switch parallel encrypt task to use callable interface.
- Use parallelStream to generate the (in-memory) exponent table.
- Run some test material through the parallel path.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tellison/incubator-pirk EncryptQuery
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
----
commit 0e4ae21d55c253017f7ba2883ff8d64bb31d486a
Author: Tim Ellison <t....@gmail.com>
Date: 2016-08-22T15:50:50Z
Enhancements to parallelism of query encryption.
- Switch parallel encrypt task to use callable interface.
- Use parallelStream to generate the (in-memory) exponent table.
- Run some test material through the parallel path.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #75: Enhancements to parallelism of query encryption.
Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/75
+1 - nice streamlining
I will run the distributed tests before merging - if merged and the PR closed, please assume that the tests passed. If not, I will report back accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #75: Enhancements to parallelism of query encryption.
Posted by tellison <gi...@git.apache.org>.
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/75
Not tested on distributed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #75: Enhancements to parallelism of query encryp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/75
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #75: Enhancements to parallelism of query encryp...
Posted by tellison <gi...@git.apache.org>.
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/75#discussion_r75758251
--- Diff: src/main/java/org/apache/pirk/query/wideskies/Query.java ---
@@ -136,89 +124,30 @@ public boolean containsElement(BigInteger element)
return queryElements.containsValue(element);
}
- public void clearElements()
- {
- queryElements.clear();
- }
-
/**
* This should be called after all query elements have been added in order to generate the expTable. For int exponentiation with BigIntegers, assumes that
* dataPartitionBitSize < 32.
- *
*/
- public void generateExpTable(int numThreads) throws InterruptedException
+ public void generateExpTable()
--- End diff --
I want to draw attention to this part of the new code, that will use the ```ForkJoinPool#commonPool()``` (i.e. all available processors by default). We can put this into a smaller custom pool if it is desirable to have that restriction.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #75: Enhancements to parallelism of query encryp...
Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/75#discussion_r75882219
--- Diff: src/main/java/org/apache/pirk/query/wideskies/Query.java ---
@@ -136,89 +124,30 @@ public boolean containsElement(BigInteger element)
return queryElements.containsValue(element);
}
- public void clearElements()
- {
- queryElements.clear();
- }
-
/**
* This should be called after all query elements have been added in order to generate the expTable. For int exponentiation with BigIntegers, assumes that
* dataPartitionBitSize < 32.
- *
*/
- public void generateExpTable(int numThreads) throws InterruptedException
+ public void generateExpTable()
--- End diff --
Allowing this computation to use all possible resources makes sense here...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---