You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/10/13 05:56:35 UTC
[GitHub] [hive] pthariensflame opened a new pull request #2719: Fix flakiness in test in `standalone-metastore`
pthariensflame opened a new pull request #2719:
URL: https://github.com/apache/hive/pull/2719
### What changes were proposed in this pull request?
The test method `org.apache.hadoop.hive.metastore.utils.TestMetaStoreServerUtils.testGetPartitionspecsGroupedBySDonePartitionCombined` creates a `List<PartitionSpec>` that was order-unstable under [NonDex](https://github.com/TestingResearchIllinois/NonDex); sorting it ensures that the partitions are in a known order while preserving the intent of the test.
### Why are the changes needed?
This test passes as is, but if the implementation of `MetaStoreServerUtils.getPartitionspecsGroupedByStorageDescriptor` were to ever change order, even implicitly through a changed dependency, then the test would break. This PR fixes the test to no longer depend on the order of partitions returned.
### Does this PR introduce _any_ user-facing change?
No; this only alters one test, that was already passing normally, to additionally pass if the latent order-instability ends up happening in practice.
### How was this patch tested?
The test itself was run before alteration, both normally (to ensure it already passed) and with NonDex (to confirm the flakiness); it was then run again in both ways after alteration, at which point both normal and NonDex runs passed, including over 150 different seeds for the latter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #2719: Fix flakiness in test in `standalone-metastore`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #2719:
URL: https://github.com/apache/hive/pull/2719#issuecomment-992000252
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pthariensflame commented on pull request #2719: Fix flakiness in test in `standalone-metastore`
Posted by GitBox <gi...@apache.org>.
pthariensflame commented on pull request #2719:
URL: https://github.com/apache/hive/pull/2719#issuecomment-942728100
Seems like the tests need to be rerun? The only failure was after the testing was already done on one split.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #2719: Fix flakiness in test in `standalone-metastore`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #2719:
URL: https://github.com/apache/hive/pull/2719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org