You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/08/11 15:22:05 UTC

Review Request 37355: AMS is doing a (Select *) for certain point in time metrics from Dashboard page

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37355/
-----------------------------------------------------------

Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.


Bugs: AMBARI-12718
    https://issues.apache.org/jira/browse/AMBARI-12718


Repository: ambari


Description
-------

API calls for certain point in time metrics are fetching data for 1 day.
API:
http://hostname:6188/ws/v1/timeline/metrics?metricNames=dfs.FSNamesystem.MissingReplOneBlocks%2Cdfs.FSNamesystem.TransactionsSinceLastCheckpoint%2Cdfs.FSNamesystem.MillisSinceLastLoadedEdits%2Cdfs.FSNamesystem.SnapshottableDi rectories%2Cdfs.FSNamesystem.LastCheckpointTime%2Cdfs.FSNamesystem.TotalFiles%2Cmaster.Master.QueueCallTime_median%2Cdfs.FSNamesystem.ExpiredHeartbeats%2Cdfs.FSNamesystem.PostponedMisreplicatedBlocks%2Cdfs.FSNamesystem.LastWrittenTransactionId%2Cdfs.FSNamesystem.Snapshots%2Cjvm.JvmMetrics.MemHeapCommittedM%2Cdfs.FSNamesystem.TransactionsSinceLastLog Roll%2Cmaster.Server.averageLoad%2Cjvm.JvmMetrics.MemHeapUsedM%2Cdfs.FSNamesystem.PendingDataNodeMessageCount%2Cmaster.AssignmentManger.ritCount%2Cdfs.FSNamesystem.StaleDataNodes&hostname=namenode_hostnamel&appId=NAMENODE
Returned result on a cluster > 1 day old takes very long time.
The call should return 1 latest value for each metric vs all values.


Diffs
-----

  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java 4ca1b4b 
  ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java ee7a468 

Diff: https://reviews.apache.org/r/37355/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 37355: AMS is doing a (Select *) for certain point in time metrics from Dashboard page

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37355/#review94922
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On Aug. 11, 2015, 1:22 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37355/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 1:22 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-12718
>     https://issues.apache.org/jira/browse/AMBARI-12718
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> API calls for certain point in time metrics are fetching data for 1 day.
> API:
> http://hostname:6188/ws/v1/timeline/metrics?metricNames=dfs.FSNamesystem.MissingReplOneBlocks%2Cdfs.FSNamesystem.TransactionsSinceLastCheckpoint%2Cdfs.FSNamesystem.MillisSinceLastLoadedEdits%2Cdfs.FSNamesystem.SnapshottableDi rectories%2Cdfs.FSNamesystem.LastCheckpointTime%2Cdfs.FSNamesystem.TotalFiles%2Cmaster.Master.QueueCallTime_median%2Cdfs.FSNamesystem.ExpiredHeartbeats%2Cdfs.FSNamesystem.PostponedMisreplicatedBlocks%2Cdfs.FSNamesystem.LastWrittenTransactionId%2Cdfs.FSNamesystem.Snapshots%2Cjvm.JvmMetrics.MemHeapCommittedM%2Cdfs.FSNamesystem.TransactionsSinceLastLog Roll%2Cmaster.Server.averageLoad%2Cjvm.JvmMetrics.MemHeapUsedM%2Cdfs.FSNamesystem.PendingDataNodeMessageCount%2Cmaster.AssignmentManger.ritCount%2Cdfs.FSNamesystem.StaleDataNodes&hostname=namenode_hostnamel&appId=NAMENODE
> Returned result on a cluster > 1 day old takes very long time.
> The call should return 1 latest value for each metric vs all values.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java 4ca1b4b 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java ee7a468 
> 
> Diff: https://reviews.apache.org/r/37355/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>