You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/11 21:21:09 UTC
[GitHub] [airflow] kaxil opened a new pull request #7694: WIP:
[AIRFLOW-5948] Replace SimpleDag with SerializedDag
kaxil opened a new pull request #7694: WIP: [AIRFLOW-5948] Replace SimpleDag with SerializedDag
URL: https://github.com/apache/airflow/pull/7694
Replace SimpleDag with serialized version (json over multiprocessing) in SchedulerJob etc., no other change in scheduler behaviour. (This doesn't make sense long term, but does tidy up the code)
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7694: [AIRFLOW-5948][WIP]
Replace SimpleDag with SerializedDag
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7694: [AIRFLOW-5948][WIP] Replace SimpleDag with SerializedDag
URL: https://github.com/apache/airflow/pull/7694#issuecomment-597946217
> this is great, I assume we are going to consolidate with single serde form in the future for Airflow which is json?
>
> also cc @KevinYang21 who may be interested in this pr
That is correct, however, this particular PR is still WIP :)
DAG Serialisation work should be completed for the Webserver once the following PRs are merged:
- https://github.com/apache/airflow/pull/6788
- https://github.com/apache/airflow/pull/7633
- https://github.com/apache/airflow/pull/7217
With the current PR, we start DAG Serialization work in the Scheduler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feng-tao commented on issue #7694: [AIRFLOW-5948][WIP]
Replace SimpleDag with SerializedDag
Posted by GitBox <gi...@apache.org>.
feng-tao commented on issue #7694: [AIRFLOW-5948][WIP] Replace SimpleDag with SerializedDag
URL: https://github.com/apache/airflow/pull/7694#issuecomment-597944091
this is great, I assume we are going to consolidate with single serde form in the future for Airflow which is json?
also cc @KevinYang21 who may be interested in this pr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services