You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/06 13:23:08 UTC
[GitHub] [incubator-doris] zhannngchen opened a new pull request, #8874: [refactor] some code cleanup for min/max function.
zhannngchen opened a new pull request, #8874:
URL: https://github.com/apache/incubator-doris/pull/8874
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8874: [refactor] some code cleanup for min/max function.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8874:
URL: https://github.com/apache/incubator-doris/pull/8874#issuecomment-1109976034
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #8874: [refactor] some code cleanup for min/max function.
Posted by GitBox <gi...@apache.org>.
morningman merged PR #8874:
URL: https://github.com/apache/incubator-doris/pull/8874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhannngchen commented on a diff in pull request #8874: [refactor] some code cleanup for min/max function.
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on code in PR #8874:
URL: https://github.com/apache/incubator-doris/pull/8874#discussion_r851862932
##########
be/src/exprs/aggregate_functions.cpp:
##########
@@ -654,22 +654,6 @@ void AggregateFunctions::min(FunctionContext*, const DecimalV2Val& src, DecimalV
}
}
-template <>
-void AggregateFunctions::min(FunctionContext*, const LargeIntVal& src, LargeIntVal* dst) {
- if (src.is_null) {
Review Comment:
The implementation for LargeIntValue is totally duplicate with the template function of min/max, I removed these code and add a template instance for LargeIntValue type, see L2543 and L2593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhannngchen commented on pull request #8874: [refactor] some code cleanup for min/max function.
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on PR #8874:
URL: https://github.com/apache/incubator-doris/pull/8874#issuecomment-1103896956
@yiguolei @morningman
Do you have time to help to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8874: [refactor] some code cleanup for min/max function.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8874:
URL: https://github.com/apache/incubator-doris/pull/8874#issuecomment-1109975992
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #8874: [refactor] some code cleanup for min/max function.
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #8874:
URL: https://github.com/apache/incubator-doris/pull/8874#discussion_r851593774
##########
be/src/exprs/aggregate_functions.cpp:
##########
@@ -654,22 +654,6 @@ void AggregateFunctions::min(FunctionContext*, const DecimalV2Val& src, DecimalV
}
}
-template <>
-void AggregateFunctions::min(FunctionContext*, const LargeIntVal& src, LargeIntVal* dst) {
- if (src.is_null) {
Review Comment:
why delete this function? LargeIntValue is not used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8874: [refactor] some code cleanup for min/max function.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8874:
URL: https://github.com/apache/incubator-doris/pull/8874#issuecomment-1114247825
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org