[Rng] Sonar 'bugs'

[Alex Herbert <al...@gmail.com>]

I noted that the Sonar job is no longer failing on Jenkins. Well done for fixing it.

I looked at the report and it has two bugs for testing floating point equality using ‘==‘. These are not bugs. I have added unit tests to demonstrate that the math implemented in the samplers should work when using the next value after the critical value.

Please review the tests and then perhaps the sonar bugs can be added to the ‘won’t fix’ list.

UnitSphereSamplerTest.testNextNormSquaredAfterZeroIsValid
GeometricSamplerTest.testProbabilityOfSuccessUnderOneIsValid

Alex


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [Rng] Sonar 'bugs'

[Gilles Sadowski <gi...@gmail.com>]

Hi.

Le dim. 3 mars 2019 à 17:34, Alex Herbert <al...@gmail.com> a écrit :
>
> I noted that the Sonar job is no longer failing on Jenkins. Well done for fixing it.

Thanks go to Gavin (INFRA):
    https://issues.apache.org/jira/browse/INFRA-17873

>
> I looked at the report and it has two bugs for testing floating point equality using ‘==‘. These are not bugs.

Sure. ;-)

> I have added unit tests to demonstrate that the math implemented in the samplers should work when using the next value after the critical value.

Great!

>
> Please review the tests and then perhaps the sonar bugs can be added to the ‘won’t fix’ list.

Done.

Regards,
Gilles

>
> UnitSphereSamplerTest.testNextNormSquaredAfterZeroIsValid
> GeometricSamplerTest.testProbabilityOfSuccessUnderOneIsValid
>
> Alex
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org