You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/10 10:19:23 UTC

[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #309: Simplify math expression code (use unary kernel)

Dandandan commented on a change in pull request #309:
URL: https://github.com/apache/arrow-datafusion/pull/309#discussion_r629241387



##########
File path: datafusion/tests/sql.rs
##########
@@ -631,7 +631,7 @@ async fn sqrt_f32_vs_f64() -> Result<()> {
     // sqrt(f32)'s plan passes
     let sql = "SELECT avg(sqrt(c11)) FROM aggregate_test_100";
     let actual = execute(&mut ctx, sql).await;
-    let expected = vec![vec!["0.6584408485889435"]];
+    let expected = vec![vec!["0.6584407806396484"]];

Review comment:
       Small diff, Isince we avoid `as f64` now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org