You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "hughhhh (GitHub)" <gi...@apache.org> on 2018/08/27 03:03:17 UTC
[GitHub] [incubator-superset] hughhhh opened pull request #5737: Add
modules to sandbox.js
Updated color package to use d3-color and added package to encode/decode geohashes
@betodealmeida @mistercrunch
[ Full content available at: https://github.com/apache/incubator-superset/pull/5737 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-superset] hughhhh commented on issue #5737: Add
modules to sandbox.js
Posted by "hughhhh (GitHub)" <gi...@apache.org>.
@mistercrunch I see a lot of our users wanting adhoc transforms on the geo data. I wanted it here to allow us to do custom encoding/decoding just incase they want to do more things. I get that the backend has some but its not a catch all in my opinion. We can continue to iterate and move more of the functionality into the controls when we see fit which is what we've been doing.
@kristw We've been mostly using it for deckgl animations and gradients based upon the rows metadata. Here's an example deck.gl has for setting the color based upon density http://deck.gl/#/documentation/deckgl-api-reference/layers/polygon-layer. I also thing adding `d3-scale-chromatic` would dope too
@williaster backward compatibility +1 with what @mistercrunch mentioned.
[ Full content available at: https://github.com/apache/incubator-superset/pull/5737 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #5737:
Add modules to sandbox.js
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=h1) Report
> Merging [#5737](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f83ea233c7c4ef327020ac57d5602a2361adfc91?src=pr&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5737 +/- ##
==========================================
+ Coverage 63.38% 63.46% +0.07%
==========================================
Files 361 361
Lines 23000 23055 +55
Branches 2559 2559
==========================================
+ Hits 14579 14632 +53
- Misses 8406 8408 +2
Partials 15 15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/modules/sandbox.js](https://codecov.io/gh/apache/incubator-superset/pull/5737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9tb2R1bGVzL3NhbmRib3guanM=) | `94.11% <100%> (+0.36%)` | :arrow_up: |
| [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/5737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `89.76% <0%> (+0.63%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=footer). Last update [f83ea23...cd8ecdf](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-superset/pull/5737 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-superset] kristw commented on issue #5737: Add
modules to sandbox.js
Posted by "kristw (GitHub)" <gi...@apache.org>.
What would be example of how user use `d3-color` in the sandbox? I am not sure we want to expose too many libraries in the sandbox. One thing to consider is it also adds a constraint for us when upgrading or switching library because there is no easy way to check if this will break these js code in sandbox. For example, now the codebase is stuck with `underscore` 1.8.x, although I would prefer to switch to `lodash` or at least update `underscore` to latest version.
[ Full content available at: https://github.com/apache/incubator-superset/pull/5737 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-superset] kristw commented on issue #5737: Add
modules to sandbox.js
Posted by "kristw (GitHub)" <gi...@apache.org>.
What would be example of how user use `d3-color` in the sandbox? I am not sure we want to expose too many libraries in the sandbox. One thing to consider is it also adds a constraint for us when upgrading or switching library because there is no easy way to check if this will break these js code in sandbox. For example, now the codebase is stuck with `underscore` 1.8.x, although I would prefer to switch to `lodash`
[ Full content available at: https://github.com/apache/incubator-superset/pull/5737 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #5737:
Add modules to sandbox.js
Posted by "mistercrunch (GitHub)" <gi...@apache.org>.
I'd say for now and until this really settles we'd just post in `UPDATING.md` when breaking backward compatibility.
[ Full content available at: https://github.com/apache/incubator-superset/pull/5737 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #5737:
Add modules to sandbox.js
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=h1) Report
> Merging [#5737](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f83ea233c7c4ef327020ac57d5602a2361adfc91?src=pr&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5737 +/- ##
==========================================
+ Coverage 63.38% 63.46% +0.07%
==========================================
Files 361 361
Lines 23000 23055 +55
Branches 2559 2559
==========================================
+ Hits 14579 14632 +53
- Misses 8406 8408 +2
Partials 15 15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/modules/sandbox.js](https://codecov.io/gh/apache/incubator-superset/pull/5737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9tb2R1bGVzL3NhbmRib3guanM=) | `94.11% <100%> (+0.36%)` | :arrow_up: |
| [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/5737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `89.76% <0%> (+0.63%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=footer). Last update [f83ea23...cd8ecdf](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-superset/pull/5737 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-superset] williaster commented on issue #5737:
Add modules to sandbox.js
Posted by "williaster (GitHub)" <gi...@apache.org>.
yeah @mistercrunch @hughhhh what are your thoughts on breaking backward compatibility for libraries that are exposed there?
I feel like at one point we discussed breaking changes being okay because this is a power-user feature (similar to custom css on dashboards) .
[ Full content available at: https://github.com/apache/incubator-superset/pull/5737 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #5737:
Add modules to sandbox.js
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=h1) Report
> Merging [#5737](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f83ea233c7c4ef327020ac57d5602a2361adfc91?src=pr&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5737 +/- ##
==========================================
+ Coverage 63.38% 63.46% +0.07%
==========================================
Files 361 361
Lines 23000 23055 +55
Branches 2559 2559
==========================================
+ Hits 14579 14632 +53
- Misses 8406 8408 +2
Partials 15 15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/modules/sandbox.js](https://codecov.io/gh/apache/incubator-superset/pull/5737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9tb2R1bGVzL3NhbmRib3guanM=) | `94.11% <100%> (+0.36%)` | :arrow_up: |
| [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/5737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `89.76% <0%> (+0.63%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=footer). Last update [f83ea23...cd8ecdf](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-superset/pull/5737 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #5737:
Add modules to sandbox.js
Posted by "mistercrunch (GitHub)" <gi...@apache.org>.
Good call on making d3-color available, but I'm wondering what users would do with the geohash lib assuming that Superset deals with this in the backend.
[ Full content available at: https://github.com/apache/incubator-superset/pull/5737 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #5737:
Add modules to sandbox.js
Posted by "mistercrunch (GitHub)" <gi...@apache.org>.
I'd say for now and until this really settles we'd just post in `UPDATING.md` when breaking backward compatibility. I'd assume things like lodash and undescore are 99% backward compatible with themselves, except on major release and even there it's probably mostly safe to move forward.
[ Full content available at: https://github.com/apache/incubator-superset/pull/5737 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #5737:
Add modules to sandbox.js
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=h1) Report
> Merging [#5737](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f83ea233c7c4ef327020ac57d5602a2361adfc91?src=pr&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5737 +/- ##
==========================================
+ Coverage 63.38% 63.46% +0.07%
==========================================
Files 361 361
Lines 23000 23055 +55
Branches 2559 2559
==========================================
+ Hits 14579 14632 +53
- Misses 8406 8408 +2
Partials 15 15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/modules/sandbox.js](https://codecov.io/gh/apache/incubator-superset/pull/5737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9tb2R1bGVzL3NhbmRib3guanM=) | `94.11% <100%> (+0.36%)` | :arrow_up: |
| [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/5737/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `89.76% <0%> (+0.63%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=footer). Last update [f83ea23...cd8ecdf](https://codecov.io/gh/apache/incubator-superset/pull/5737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-superset/pull/5737 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-superset] hughhhh closed pull request #5737: Add
modules to sandbox.js
Posted by "hughhhh (GitHub)" <gi...@apache.org>.
[ pull request closed by hughhhh ]
[ Full content available at: https://github.com/apache/incubator-superset/pull/5737 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org