You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/09/25 03:57:06 UTC

Review Request 26014: Quick fix for cron error.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26014/
-----------------------------------------------------------

Review request for Aurora, Bill Farner and Zameer Manji.


Bugs: aurora-753
    https://issues.apache.org/jira/browse/aurora-753


Repository: aurora


Description
-------

Damned python indent-syntax - else clause attached to "if" rather than "for".


Diffs
-----

  src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 

Diff: https://reviews.apache.org/r/26014/diff/


Testing
-------

Quick fix: no additional test. I'll add a regression test when rosh hashanah is over.


Thanks,

Mark Chu-Carroll

Re: Review Request 26014: Quick fix for cron error.

Posted by Bill Farner <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26014/#review54498
-----------------------------------------------------------


Fix + test is up here: https://reviews.apache.org/r/26015/

- Bill Farner


On Sept. 25, 2014, 1:57 a.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26014/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2014, 1:57 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: aurora-753
>     https://issues.apache.org/jira/browse/aurora-753
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Damned python indent-syntax - else clause attached to "if" rather than "for".
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 
> 
> Diff: https://reviews.apache.org/r/26014/diff/
> 
> 
> Testing
> -------
> 
> Quick fix: no additional test. I'll add a regression test when rosh hashanah is over.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>