You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2021/05/31 23:41:32 UTC

[commons-math] 01/02: Additional test passes.

This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-math.git

commit c3ec07380f82c868dd015cf83f3ee2575c6fcd51
Author: Gilles Sadowski <gi...@gmail.com>
AuthorDate: Tue Jun 1 01:25:15 2021 +0200

    Additional test passes.
---
 .../legacy/core/ExtendedFieldElementAbstractTest.java      | 14 ++++++--------
 .../legacy/field/ExtendedFieldElementAbstractTest.java     | 14 ++++++--------
 2 files changed, 12 insertions(+), 16 deletions(-)

diff --git a/commons-math-legacy-core/src/test/java/org/apache/commons/math4/legacy/core/ExtendedFieldElementAbstractTest.java b/commons-math-legacy-core/src/test/java/org/apache/commons/math4/legacy/core/ExtendedFieldElementAbstractTest.java
index 7f5087c..ec34fcb 100644
--- a/commons-math-legacy-core/src/test/java/org/apache/commons/math4/legacy/core/ExtendedFieldElementAbstractTest.java
+++ b/commons-math-legacy-core/src/test/java/org/apache/commons/math4/legacy/core/ExtendedFieldElementAbstractTest.java
@@ -313,14 +313,12 @@ public abstract class ExtendedFieldElementAbstractTest<T extends RealFieldElemen
         }
     }
 
-//  TODO: add this test in 4.0, as it is not possible to do it in 3.2
-//  due to incompatibility of the return type in the Dfp class
-//    @Test
-//    public void testLog10() {
-//        for (double x = -0.9; x < 0.9; x += 0.05) {
-//            checkRelative(AccurateMath.log10(x), build(x).log10());
-//        }
-//    }
+    @Test
+    public void testLog10() {
+        for (double x = -0.9; x < 0.9; x += 0.05) {
+            checkRelative(AccurateMath.log10(x), build(x).log10());
+        }
+    }
 
     @Test
     public void testAbs() {
diff --git a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/field/ExtendedFieldElementAbstractTest.java b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/field/ExtendedFieldElementAbstractTest.java
index a1b2670..81a1e60 100644
--- a/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/field/ExtendedFieldElementAbstractTest.java
+++ b/commons-math-legacy/src/test/java/org/apache/commons/math4/legacy/field/ExtendedFieldElementAbstractTest.java
@@ -315,14 +315,12 @@ public abstract class ExtendedFieldElementAbstractTest<T extends RealFieldElemen
         }
     }
 
-//  TODO: add this test in 4.0, as it is not possible to do it in 3.2
-//  due to incompatibility of the return type in the Dfp class
-//    @Test
-//    public void testLog10() {
-//        for (double x = -0.9; x < 0.9; x += 0.05) {
-//            checkRelative(AccurateMath.log10(x), build(x).log10());
-//        }
-//    }
+    @Test
+    public void testLog10() {
+        for (double x = -0.9; x < 0.9; x += 0.05) {
+            checkRelative(AccurateMath.log10(x), build(x).log10());
+        }
+    }
 
     @Test
     public void testAbs() {