You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2025/08/18 05:06:12 UTC
[PR] [SPARK-53305][PYTHON] Support TimeType in createDataFrame [spark]
zhengruifeng opened a new pull request, #52058:
URL: https://github.com/apache/spark/pull/52058
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Support TimeType in createDataFrame
### Why are the changes needed?
```
In [1]: import datetime
In [2]: spark.createDataFrame([(datetime.time(12,10,1),)])
---------------------------------------------------------------------------
AttributeError Traceback (most recent call last)
Cell In[2], line 1
----> 1 spark.createDataFrame([(datetime.time(12,10,1),)])
...
File ~/spark/python/pyspark/sql/types.py:441, in TimestampType.toInternal(self, dt)
438 def toInternal(self, dt: datetime.datetime) -> int:
439 if dt is not None:
440 seconds = (
--> 441 calendar.timegm(dt.utctimetuple()) if dt.tzinfo else time.mktime(dt.timetuple())
442 )
443 return int(seconds) * 1000000 + dt.microsecond
AttributeError: 'datetime.time' object has no attribute 'timetuple'
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
new tests
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53305][PYTHON] Support TimeType in createDataFrame [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #52058:
URL: https://github.com/apache/spark/pull/52058#discussion_r2281309374
##########
python/pyspark/sql/types.py:
##########
@@ -2148,7 +2148,7 @@ def _assert_valid_collation_provider(provider: str) -> None:
decimal.Decimal: DecimalType,
datetime.date: DateType,
datetime.datetime: TimestampType, # can be TimestampNTZType
- datetime.time: TimestampType, # can be TimestampNTZType
+ datetime.time: TimeType,
Review Comment:
The inferred type of `datetime.time` will be `TimeType`.
But I think it is not a behavior change, since `datetime.time` is never a accepted type for `TimestampType`
https://github.com/apache/spark/blob/19ea6ff95ef334cf9655c6b29b5a0123ebf58d87/python/pyspark/sql/types.py#L2687-L2690
manually check that createDF with `datetime.time` never work before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53305][PYTHON] Support TimeType in createDataFrame [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #52058: [SPARK-53305][PYTHON] Support TimeType in createDataFrame
URL: https://github.com/apache/spark/pull/52058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53305][PYTHON] Support TimeType in createDataFrame [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #52058:
URL: https://github.com/apache/spark/pull/52058#issuecomment-3196025404
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org