You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/11/13 23:42:29 UTC
[GitHub] vdantu commented on a change in pull request #13246: Addressed
sphinx build issue
vdantu commented on a change in pull request #13246: Addressed sphinx build issue
URL: https://github.com/apache/incubator-mxnet/pull/13246#discussion_r233266007
##########
File path: docs/_static/js/auto_module_index.js
##########
@@ -10,15 +10,17 @@ function auto_index(module) {
var html = "<ul>";
for (var i = 0; i < targets.length; ++i) {
- var id = $(targets[i]).attr('id');
- // remove 'mxnet.' prefix to make menus shorter
- var id_simple = id.replace(/^mxnet\./, '');
- html += "<li><a class='reference internal' href='#";
- html += id;
- html += "'>" + id_simple + "</a></li>";
+ var id = $(targets[i]).attr('id');
+ if ( id ) {
Review comment:
I added a short note in the PR section describing the change. Please feel free to correct my understanding if I am wrong :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services