You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "klion26 (via GitHub)" <gi...@apache.org> on 2024/11/15 02:31:41 UTC
[I] [Improvement]: Improve the LICENSE and NOTICE file [amoro]
klion26 opened a new issue, #3333:
URL: https://github.com/apache/amoro/issues/3333
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/amoro/issues?q=is%3Aissue) and found no similar issues.
### What would you like to be improved?
There are some improvements for LICENSE and NOTICE when [voting](https://lists.apache.org/thread/kb745933oqybcjz9o0454lrxw9d01p2d) for 0.7.1-incubating, we need to improve them.
> - in LICENSE-binary you're pointing to the licenses/ folder, but there is only a licenses-binary/ folder. I'm assuming the reference can just be fixed.
> In NOTICE it is unclear why Apache Iceberg, Apache Paimon or Apache Flink are listed as they are not mentioned in LICENSE. Most projects will list files copied from other ASF projects in LICENSE.
> In LICENSE, these ALv2.0 licensed files are not mentioned which are not ASF files:
> ./charts/amoro/templates/common/_names.tpl
> ./charts/amoro/templates/common/_capabilities.tpl
> ./charts/amoro/templates/common/_tplvalues.tpl
> ./charts/amoro/templates/common/_ingress.tpl
> ./charts/amoro/templates/common/_labels.tpl
### How should we improve?
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Subtasks
_No response_
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Improvement]: Improve the LICENSE and NOTICE file [amoro]
Posted by "klion26 (via GitHub)" <gi...@apache.org>.
klion26 commented on issue #3333:
URL: https://github.com/apache/amoro/issues/3333#issuecomment-2482865379
As [lincense](https://github.com/bitnami/charts/tree/common/2.11.1?tab=License-1-ov-file) of bitnami/charts say, it's Apache License
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Improvement]: Improve the LICENSE and NOTICE file [amoro]
Posted by "klion26 (via GitHub)" <gi...@apache.org>.
klion26 commented on issue #3333:
URL: https://github.com/apache/amoro/issues/3333#issuecomment-2510645213
want to improve this by
1. will add the files listed above(`./charts/amoro/templates/commont/*.tpl`) to the LICENSE
2. want to rename the `license-binary` folder to `license`, and collect the final license entries ref to Flink's [collect_license_files](https://github.com/apache/flink/blob/master/tools/releasing/collect_license_files.sh)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Improvement]: Improve the LICENSE and NOTICE file [amoro]
Posted by "baiyangtx (via GitHub)" <gi...@apache.org>.
baiyangtx closed issue #3333: [Improvement]: Improve the LICENSE and NOTICE file
URL: https://github.com/apache/amoro/issues/3333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org