[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11490: Ensure dataStream is closed even when offsetStream fails to flush

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #11490:
URL: https://github.com/apache/pinot/pull/11490#discussion_r1313587182


##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/genericrow/GenericRowFileWriter.java:
##########
@@ -29,7 +29,6 @@
 import org.apache.pinot.spi.data.FieldSpec;
 import org.apache.pinot.spi.data.readers.GenericRow;
 
-

Review Comment:
   (minor, code format) When I auto reformat the file, Pinot Style will leave 2 empty lines here



##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/genericrow/GenericRowFileWriter.java:
##########
@@ -66,7 +65,10 @@ public void write(GenericRow genericRow)
   @Override
   public void close()
       throws IOException {
-    _offsetStream.close();
-    _dataStream.close();
+    try {

Review Comment:
   Please add some comments here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org