[GitHub] ashutosh-bapat commented on a change in pull request #537: HIVE-19430 : ObjectStore.cleanNotificationEvents OutOfMemory on large number of pending events

[GitBox <gi...@apache.org>]

ashutosh-bapat commented on a change in pull request #537: HIVE-19430 : ObjectStore.cleanNotificationEvents OutOfMemory on large number of pending events
URL: https://github.com/apache/hive/pull/537#discussion_r257211237
 
 

 ##########
 File path: hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
 ##########
 @@ -1142,10 +1142,8 @@ public void run() {
         } catch (Exception ex) {
           //catching exceptions here makes sure that the thread doesn't die in case of unexpected
           //exceptions
-          LOG.warn(
-              "Exception received while cleaning notifications. More details can be found in debug mode"
-                  + ex.getMessage());
-          LOG.debug(ex.getMessage(), ex);
 
 Review comment:
   There is no point in dropping a warning with just the exception message and asking user to turn on debug level to investigate further. An exception has happened and if we are giving out "warn"ing better we also log the exception accompanying it instead of a separate debug message. WARN has higher priority than debug.
   
   It will make the logs slightly verbose but will be more useful in production environment where changing log level isn't that easy.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services