You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "hailin0 (via GitHub)" <gi...@apache.org> on 2023/04/23 03:08:36 UTC
[GitHub] [shardingsphere] hailin0 opened a new pull request, #25286: Fix example generator
hailin0 opened a new pull request, #25286:
URL: https://github.com/apache/shardingsphere/pull/25286
Changes proposed in this pull request:
- Fix #25250
- Fix example output path
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix example generator [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu closed pull request #25286: Fix example generator
URL: https://github.com/apache/shardingsphere/pull/25286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] commented on pull request #25286: Fix example generator
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25286:
URL: https://github.com/apache/shardingsphere/pull/25286#issuecomment-1657254325
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on pull request #25286: Fix example generator
Posted by "totalo (via GitHub)" <gi...@apache.org>.
totalo commented on PR #25286:
URL: https://github.com/apache/shardingsphere/pull/25286#issuecomment-1519255021
hi, @hailin0 Thanks for your attention, here is a small question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] hailin0 commented on pull request #25286: Fix example generator
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #25286:
URL: https://github.com/apache/shardingsphere/pull/25286#issuecomment-1518930750
PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] boyjoy1127 commented on pull request #25286: Fix example generator
Posted by "boyjoy1127 (via GitHub)" <gi...@apache.org>.
boyjoy1127 commented on PR #25286:
URL: https://github.com/apache/shardingsphere/pull/25286#issuecomment-1585975954
Will this issue be completed before June 15 which is the final date of version 5.4.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on a diff in pull request #25286: Fix example generator
Posted by "totalo (via GitHub)" <gi...@apache.org>.
totalo commented on code in PR #25286:
URL: https://github.com/apache/shardingsphere/pull/25286#discussion_r1174707914
##########
examples/shardingsphere-example-generator/src/main/resources/config.yaml:
##########
@@ -16,7 +16,7 @@
#
output:
- - ./examples/shardingsphere-example-generator/target/generated-sources/
+ - ./shardingsphere-example-generator/target/generated-sources/
Review Comment:
This example generation is part of the examples section, so it makes sense to generate examples in the Examples directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on pull request #25286: Fix example generator
Posted by "taojintianxia (via GitHub)" <gi...@apache.org>.
taojintianxia commented on PR #25286:
URL: https://github.com/apache/shardingsphere/pull/25286#issuecomment-1738373871
this PR will migrate to milestone 5.4.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] boyjoy1127 commented on pull request #25286: Fix example generator
Posted by "boyjoy1127 (via GitHub)" <gi...@apache.org>.
boyjoy1127 commented on PR #25286:
URL: https://github.com/apache/shardingsphere/pull/25286#issuecomment-1585973874
Will this issue be completed before June 15 which is the final date of version 5.4.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix example generator [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #25286:
URL: https://github.com/apache/shardingsphere/pull/25286#issuecomment-2041700029
Since this pr has long time no response, I will close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org