You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/12/19 23:50:00 UTC

[jira] [Commented] (MWRAPPER-120) Maven wrapper plugin should not create wrapperUrl property for script-only mode

    [ https://issues.apache.org/jira/browse/MWRAPPER-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798774#comment-17798774 ] 

ASF GitHub Bot commented on MWRAPPER-120:
-----------------------------------------

bdemers opened a new pull request, #114:
URL: https://github.com/apache/maven-wrapper/pull/114

   When using the `only-script` distribution type, the `wrapperUrl` is not needed, will not be added to `maven-wrapper.properties`
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MWRAPPER-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> Maven wrapper plugin should not create wrapperUrl property for script-only mode
> -------------------------------------------------------------------------------
>
>                 Key: MWRAPPER-120
>                 URL: https://issues.apache.org/jira/browse/MWRAPPER-120
>             Project: Maven Wrapper
>          Issue Type: Bug
>            Reporter: Brian Demers
>            Priority: Major
>
> The `script-only` mode of the wrapper:wrapper should not add the `wrapperUrl` to `maven-wrapper.properties` as this property is not used.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)