You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2016/03/31 23:38:09 UTC
[GitHub] couchdb-fauxton pull request: Deleting cors domain moved to modal
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/676
Deleting cors domain moved to modal
This is part of the death-to-all-window.confirms that Justin's
leading. The delete origin is now a modal.
Two related things:
- The cors page wasn't scrolling, hence the addition of the flex-body
class on the page element.
- the ConfirmationModal component now lets you pass in a class
for the main button to change the style.
<img width="1254" alt="screen shot 2016-03-31 at 2 34 28 pm" src="https://cloud.githubusercontent.com/assets/512116/14191688/2ba1eeb2-f74e-11e5-926d-47f5bf245c81.png">
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton cors-page-modal
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/676.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #676
----
commit ed3319185a93d397698b663761488d7ad9bf6cf7
Author: Ben Keen <be...@gmail.com>
Date: 2016-03-31T21:36:57Z
Deleting cors domain moved to modal
This is part of the death-to-all-window.confirms that Justin's
leading. The delete origin is now a modal.
Two related things:
- The cors page wasn't scrolling, hence the addition of the flex-body
class on the page element.
- the ConfirmationModal component now lets you pass in a class
for the main button to change the style.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Deleting cors domain moved to modal
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/676#issuecomment-220354886
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Deleting cors domain moved to modal
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/676#discussion_r58547851
--- Diff: app/addons/fauxton/components.react.jsx ---
@@ -403,7 +405,7 @@ function (app, FauxtonAPI, React, ReactDOM, ZeroClipboard, ReactBootstrap) {
{content}
</Modal.Body>
<Modal.Footer>
- <button className="btn btn-success js-btn-success" onClick={this.props.onSubmit}>
+ <button className={btnClasses} onClick={this.props.onSubmit}>
<i className="fonticon-ok-circled"></i> {this.props.successButtonLabel}
</button>
--- End diff --
we have a component for that:
https://github.com/apache/couchdb-fauxton/blob/master/app/addons/components/react-components.react.jsx#L1119-L1149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Deleting cors domain moved to modal
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/676#discussion_r63895029
--- Diff: app/addons/components/react-components.react.jsx ---
@@ -1147,17 +1149,18 @@ define([
},
render: function () {
+ const { onClick, buttonType, id, style, text } = this.props;
--- End diff --
<3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Deleting cors domain moved to modal
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/676#issuecomment-204141459
The message is awesome! It seems I can delete google.com now (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Deleting cors domain moved to modal
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/676#discussion_r59928081
--- Diff: app/addons/fauxton/components.react.jsx ---
@@ -403,7 +405,7 @@ function (app, FauxtonAPI, React, ReactDOM, ZeroClipboard, ReactBootstrap) {
{content}
</Modal.Body>
<Modal.Footer>
- <button className="btn btn-success js-btn-success" onClick={this.props.onSubmit}>
+ <button className={btnClasses} onClick={this.props.onSubmit}>
<i className="fonticon-ok-circled"></i> {this.props.successButtonLabel}
</button>
--- End diff --
Yeah, I guess I can refactor that component to allow passing the custom classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Deleting cors domain moved to modal
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/676
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Deleting cors domain moved to modal
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/676#discussion_r63599211
--- Diff: app/addons/fauxton/components.react.jsx ---
@@ -403,7 +405,7 @@ function (app, FauxtonAPI, React, ReactDOM, ZeroClipboard, ReactBootstrap) {
{content}
</Modal.Body>
<Modal.Footer>
- <button className="btn btn-success js-btn-success" onClick={this.props.onSubmit}>
+ <button className={btnClasses} onClick={this.props.onSubmit}>
<i className="fonticon-ok-circled"></i> {this.props.successButtonLabel}
</button>
--- End diff --
Just FYI, I did try using the ConfirmButton component but ran into a circular reference problem where one file required the other. As discussed, way back when, I'm going to combine those two files + this problem will go away.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Deleting cors domain moved to modal
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/676#issuecomment-220358129
Thanks Robert. Merged as 30fdd49
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---