You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Namit Jain (Created) (JIRA)" <ji...@apache.org> on 2012/03/03 02:56:55 UTC
[jira] [Created] (HIVE-2837) insert into external tables should not
be allowed
insert into external tables should not be allowed
-------------------------------------------------
Key: HIVE-2837
URL: https://issues.apache.org/jira/browse/HIVE-2837
Project: Hive
Issue Type: Bug
Reporter: Namit Jain
Assignee: Namit Jain
This is a very risky thing to allow.
Since, the external tables can point to any user location, which can potentially corrupt some other tables.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2837) insert into external tables should
not be allowed
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266274#comment-13266274 ]
Phabricator commented on HIVE-2837:
-----------------------------------
njain has abandoned the revision "HIVE-2837 [jira] insert into external tables should not be allowed".
REVISION DETAIL
https://reviews.facebook.net/D2211
> insert into external tables should not be allowed
> -------------------------------------------------
>
> Key: HIVE-2837
> URL: https://issues.apache.org/jira/browse/HIVE-2837
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
> Fix For: 0.9.0
>
> Attachments: HIVE-2837.D2211.1.patch, HIVE-2837.D2211.2.patch
>
>
> This is a very risky thing to allow.
> Since, the external tables can point to any user location, which can potentially corrupt some other tables.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2837) insert into external tables should
not be allowed
Posted by "Alan Gates (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225286#comment-13225286 ]
Alan Gates commented on HIVE-2837:
----------------------------------
If this is to be added it should definitely be configurable, with the default off, since this is a major backwards incompatibility.
> insert into external tables should not be allowed
> -------------------------------------------------
>
> Key: HIVE-2837
> URL: https://issues.apache.org/jira/browse/HIVE-2837
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> This is a very risky thing to allow.
> Since, the external tables can point to any user location, which can potentially corrupt some other tables.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2837) insert into external tables should
not be allowed
Posted by "Mark Grover (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286907#comment-13286907 ]
Mark Grover commented on HIVE-2837:
-----------------------------------
>From looking at this, it seems like it applies to external tables on HDFS as well. Can you please confirm this is correct?
Technically, insert into should be ok for external tables on HDFS (and S3) as well. Seems like a storage file system level thing to specify whether insert into is applied and implement it.
Some context for you:
Historically, there hasn't been any real difference between creating an external table on HDFS vs creating a managed one. However, if we disallow insert into on external tables, that would mean that folks with external tables on HDFS wouldn't be able to make use of insert into functionality even though they should be able to. This would make new tables to be biased towards managed tables but what about the people who already have their entire Hive warehouses based on external tables?
> insert into external tables should not be allowed
> -------------------------------------------------
>
> Key: HIVE-2837
> URL: https://issues.apache.org/jira/browse/HIVE-2837
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
> Fix For: 0.9.0
>
> Attachments: HIVE-2837.D2211.1.patch, HIVE-2837.D2211.2.patch
>
>
> This is a very risky thing to allow.
> Since, the external tables can point to any user location, which can potentially corrupt some other tables.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2837) insert into external tables should
not be allowed
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226664#comment-13226664 ]
Hudson commented on HIVE-2837:
------------------------------
Integrated in Hive-trunk-h0.21 #1302 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1302/])
HIVE-2837. insert into external tables should not be allowed. (namit via kevinwilfong) (Revision 1298936)
Result = SUCCESS
kevinwilfong : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298936
Files :
* /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
* /hive/trunk/ql/src/test/queries/clientnegative/insertexternal1.q
* /hive/trunk/ql/src/test/results/clientnegative/insertexternal1.q.out
> insert into external tables should not be allowed
> -------------------------------------------------
>
> Key: HIVE-2837
> URL: https://issues.apache.org/jira/browse/HIVE-2837
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: HIVE-2837.D2211.1.patch, HIVE-2837.D2211.2.patch
>
>
> This is a very risky thing to allow.
> Since, the external tables can point to any user location, which can potentially corrupt some other tables.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2837) insert into external tables should
not be allowed
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225750#comment-13225750 ]
Phabricator commented on HIVE-2837:
-----------------------------------
kevinwilfong has added CCs to the revision "HIVE-2837 [jira] insert into external tables should not be allowed".
Added CCs: kevinwilfong
REVISION DETAIL
https://reviews.facebook.net/D2211
> insert into external tables should not be allowed
> -------------------------------------------------
>
> Key: HIVE-2837
> URL: https://issues.apache.org/jira/browse/HIVE-2837
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: HIVE-2837.D2211.1.patch
>
>
> This is a very risky thing to allow.
> Since, the external tables can point to any user location, which can potentially corrupt some other tables.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2837) insert into external tables should
not be allowed
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225809#comment-13225809 ]
Phabricator commented on HIVE-2837:
-----------------------------------
kevinwilfong has accepted the revision "HIVE-2837 [jira] insert into external tables should not be allowed".
+1 Will commit if tests pass.
REVISION DETAIL
https://reviews.facebook.net/D2211
BRANCH
svn
> insert into external tables should not be allowed
> -------------------------------------------------
>
> Key: HIVE-2837
> URL: https://issues.apache.org/jira/browse/HIVE-2837
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: HIVE-2837.D2211.1.patch, HIVE-2837.D2211.2.patch
>
>
> This is a very risky thing to allow.
> Since, the external tables can point to any user location, which can potentially corrupt some other tables.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2837) insert into external tables should
not be allowed
Posted by "Edward Capriolo (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221491#comment-13221491 ]
Edward Capriolo commented on HIVE-2837:
---------------------------------------
maybe add a read only keyword or table property?
> insert into external tables should not be allowed
> -------------------------------------------------
>
> Key: HIVE-2837
> URL: https://issues.apache.org/jira/browse/HIVE-2837
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> This is a very risky thing to allow.
> Since, the external tables can point to any user location, which can potentially corrupt some other tables.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2837) insert into external tables should
not be allowed
Posted by "Edward Capriolo (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221977#comment-13221977 ]
Edward Capriolo commented on HIVE-2837:
---------------------------------------
Internal tables can have a location as well.
> insert into external tables should not be allowed
> -------------------------------------------------
>
> Key: HIVE-2837
> URL: https://issues.apache.org/jira/browse/HIVE-2837
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> This is a very risky thing to allow.
> Since, the external tables can point to any user location, which can potentially corrupt some other tables.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2837) insert into external tables should not
be allowed
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2837:
------------------------------
Attachment: HIVE-2837.D2211.1.patch
njain requested code review of "HIVE-2837 [jira] insert into external tables should not be allowed".
Reviewers: JIRA
https://issues.apache.org/jira/browse/HIVE-2837
HIVE-2837 By default, the behavior does not change. It is backward compatible
This is a very risky thing to allow.
Since, the external tables can point to any user location, which can potentially corrupt some other tables.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D2211
AFFECTED FILES
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
ql/src/test/results/clientnegative/insertexternal1.q.out
ql/src/test/queries/clientnegative/insertexternal1.q
ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/4845/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> insert into external tables should not be allowed
> -------------------------------------------------
>
> Key: HIVE-2837
> URL: https://issues.apache.org/jira/browse/HIVE-2837
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: HIVE-2837.D2211.1.patch
>
>
> This is a very risky thing to allow.
> Since, the external tables can point to any user location, which can potentially corrupt some other tables.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2837) insert into external tables should
not be allowed
Posted by "Namit Jain (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221942#comment-13221942 ]
Namit Jain commented on HIVE-2837:
----------------------------------
I dont want to it table-by-table.
The only other option I can think of is add another configuration variable.
> insert into external tables should not be allowed
> -------------------------------------------------
>
> Key: HIVE-2837
> URL: https://issues.apache.org/jira/browse/HIVE-2837
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
>
> This is a very risky thing to allow.
> Since, the external tables can point to any user location, which can potentially corrupt some other tables.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2837) insert into external tables should not
be allowed
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2837:
-----------------------------------
Fix Version/s: 0.9.0
> insert into external tables should not be allowed
> -------------------------------------------------
>
> Key: HIVE-2837
> URL: https://issues.apache.org/jira/browse/HIVE-2837
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
> Fix For: 0.9.0
>
> Attachments: HIVE-2837.D2211.1.patch, HIVE-2837.D2211.2.patch
>
>
> This is a very risky thing to allow.
> Since, the external tables can point to any user location, which can potentially corrupt some other tables.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2837) insert into external tables should not
be allowed
Posted by "Namit Jain (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-2837:
-----------------------------
Status: Patch Available (was: Open)
> insert into external tables should not be allowed
> -------------------------------------------------
>
> Key: HIVE-2837
> URL: https://issues.apache.org/jira/browse/HIVE-2837
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: HIVE-2837.D2211.1.patch
>
>
> This is a very risky thing to allow.
> Since, the external tables can point to any user location, which can potentially corrupt some other tables.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2837) insert into external tables should not
be allowed
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2837:
------------------------------
Attachment: HIVE-2837.D2211.2.patch
njain updated the revision "HIVE-2837 [jira] insert into external tables should not be allowed".
Reviewers: JIRA
Change error message
REVISION DETAIL
https://reviews.facebook.net/D2211
AFFECTED FILES
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
ql/src/test/results/clientnegative/insertexternal1.q.out
ql/src/test/queries/clientnegative/insertexternal1.q
ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
> insert into external tables should not be allowed
> -------------------------------------------------
>
> Key: HIVE-2837
> URL: https://issues.apache.org/jira/browse/HIVE-2837
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: HIVE-2837.D2211.1.patch, HIVE-2837.D2211.2.patch
>
>
> This is a very risky thing to allow.
> Since, the external tables can point to any user location, which can potentially corrupt some other tables.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2837) insert into external tables should not
be allowed
Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-2837:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed, thanks Namit.
> insert into external tables should not be allowed
> -------------------------------------------------
>
> Key: HIVE-2837
> URL: https://issues.apache.org/jira/browse/HIVE-2837
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: HIVE-2837.D2211.1.patch, HIVE-2837.D2211.2.patch
>
>
> This is a very risky thing to allow.
> Since, the external tables can point to any user location, which can potentially corrupt some other tables.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2837) insert into external tables should
not be allowed
Posted by "Namit Jain (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225724#comment-13225724 ]
Namit Jain commented on HIVE-2837:
----------------------------------
I have added a new parameter: hive.insert.into.external.tables which is true by default.
If you set it to false explicitly, the inserts will fail.
> insert into external tables should not be allowed
> -------------------------------------------------
>
> Key: HIVE-2837
> URL: https://issues.apache.org/jira/browse/HIVE-2837
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: HIVE-2837.D2211.1.patch
>
>
> This is a very risky thing to allow.
> Since, the external tables can point to any user location, which can potentially corrupt some other tables.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira