You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "romainmoreau (via GitHub)" <gi...@apache.org> on 2024/07/13 08:26:38 UTC
[PR] [IMPROVEMENT] results handlers also called for pushed line handlers [james-project]
romainmoreau opened a new pull request, #2344:
URL: https://github.com/apache/james-project/pull/2344
Some responses don't currently pass through `ProtocolHandlerResultHandler`, for instance the response to the base64 encoded identifiers after the SMTP `AUTH PLAIN` command (i.e. 235 or 535), because these responses are issued by a dynamically pushed LineHandler, so this MR adds a call to the result handlers in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [IMPROVEMENT] results handlers also called for pushed line handlers [james-project]
Posted by "romainmoreau (via GitHub)" <gi...@apache.org>.
romainmoreau closed pull request #2344: [IMPROVEMENT] results handlers also called for pushed line handlers
URL: https://github.com/apache/james-project/pull/2344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [IMPROVEMENT] results handlers also called for pushed line handlers [james-project]
Posted by "romainmoreau (via GitHub)" <gi...@apache.org>.
romainmoreau commented on PR #2344:
URL: https://github.com/apache/james-project/pull/2344#issuecomment-2227275252
My use case was getting the result of `UsersRepositoryAuthHook`; after taking a second look, I noticed there was already the `HookResultHook` mecanism but it's partially implemented on `AuthCmdHandler`, so I created #2345.
About the data lines there is already `DataLineFilter` that seem to cover this use case, so indeed this PR is not needed, I'm closing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org