[GitHub] [airflow] hussein-awala commented on a diff in pull request #29929: Adding more information to kubernetes executor logs

["hussein-awala (via GitHub)" <gi...@apache.org>]

hussein-awala commented on code in PR #29929:
URL: https://github.com/apache/airflow/pull/29929#discussion_r1125698615


##########
airflow/kubernetes/kubernetes_helper_functions.py:
##########
@@ -119,3 +120,7 @@ def annotations_to_key(annotations: dict[str, str]) -> TaskInstanceKey:
         try_number=try_number,
         map_index=map_index,
     )
+
+
+def annotations_to_str(annotations: dict[str, str]) -> str:
+    return json.dumps(annotations)

Review Comment:
   I wonder if we need to add all the annotations to the log, since we use annotations to configure log collecting and others things, maybe we can select only these keys:
   ```json
   {
     "dag_id": "dag",
     "task_id": "task",
     "run_id": "run_id",
     "try_number": "1",
     "execution_date": None,
   }
   ```
   Better wait for a second opinion before changing it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org