You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/02/04 00:08:43 UTC

[kudu-CR] [sys catalog] make visitor's code more generic

Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5901

Change subject: [sys_catalog] make visitor's code more generic
......................................................................

[sys_catalog] make visitor's code more generic

Minor refactoring on sys_catalog.{cc,h}: the visitor-related code
is made more generic to avoid code duplication.

There are no functional changes in this patch.

Change-Id: I7aa1e81ad7e61af8376ce4b52cd4020f5ce69a63
---
M src/kudu/master/sys_catalog.cc
M src/kudu/master/sys_catalog.h
2 files changed, 74 insertions(+), 77 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/5901/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7aa1e81ad7e61af8376ce4b52cd4020f5ce69a63
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [sys catalog] make visitor's code more generic

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: [sys_catalog] make visitor's code more generic
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7aa1e81ad7e61af8376ce4b52cd4020f5ce69a63
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [sys catalog] make visitor's code more generic

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: [sys_catalog] make visitor's code more generic
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5901/1/src/kudu/master/sys_catalog.cc
File src/kudu/master/sys_catalog.cc:

Line 510:   auto pred = ColumnPredicate::Equality(schema_.column(type_col_idx), &et);
> I think 'et' is just used here; how about just using entry_type directly?
Unfortunately, that's not possible:

kudu/src/kudu/master/sys_catalog.cc:510:41: error: 
      cannot take the address of an rvalue of type
      'SysCatalogTable::CatalogEntryType'
                                        &entry_type);
                                        ^~~~~~~~~~~

This seems to be a good reason to pass input variables by const reference.  But this is not the case because the interface uses void* parameter.


-- 
To view, visit http://gerrit.cloudera.org:8080/5901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7aa1e81ad7e61af8376ce4b52cd4020f5ce69a63
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [sys catalog] make visitor's code more generic

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5901

to look at the new patch set (#3).

Change subject: [sys_catalog] make visitor's code more generic
......................................................................

[sys_catalog] make visitor's code more generic

Minor refactoring on sys_catalog.{cc,h}: the visitor-related code
is made more generic to avoid code duplication.

There are no functional changes in this patch.

Change-Id: I7aa1e81ad7e61af8376ce4b52cd4020f5ce69a63
---
M src/kudu/master/sys_catalog.cc
M src/kudu/master/sys_catalog.h
2 files changed, 74 insertions(+), 77 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/5901/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7aa1e81ad7e61af8376ce4b52cd4020f5ce69a63
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [sys catalog] make visitor's code more generic

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: [sys_catalog] make visitor's code more generic
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5901/1/src/kudu/master/sys_catalog.cc
File src/kudu/master/sys_catalog.cc:

Line 478:     return visitor->VisitTable(std::move(entry_id), std::move(entry_data));
> warning: passing result of std::move() as a const reference argument; no mo
Done


Line 478:     return visitor->VisitTable(std::move(entry_id), std::move(entry_data));
> warning: passing result of std::move() as a const reference argument; no mo
Done


Line 594:                                 std::move(entry_id), std::move(entry_data));
> warning: passing result of std::move() as a const reference argument; no mo
Done


Line 594:                                 std::move(entry_id), std::move(entry_data));
> warning: passing result of std::move() as a const reference argument; no mo
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7aa1e81ad7e61af8376ce4b52cd4020f5ce69a63
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [sys catalog] make visitor's code more generic

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: [sys_catalog] make visitor's code more generic
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5901/1/src/kudu/master/sys_catalog.cc
File src/kudu/master/sys_catalog.cc:

Line 510:   auto pred = ColumnPredicate::Equality(schema_.column(type_col_idx), &et);
I think 'et' is just used here; how about just using entry_type directly?


-- 
To view, visit http://gerrit.cloudera.org:8080/5901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7aa1e81ad7e61af8376ce4b52cd4020f5ce69a63
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [sys catalog] make visitor's code more generic

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: [sys_catalog] make visitor's code more generic
......................................................................


[sys_catalog] make visitor's code more generic

Minor refactoring on sys_catalog.{cc,h}: the visitor-related code
is made more generic to avoid code duplication.

There are no functional changes in this patch.

Change-Id: I7aa1e81ad7e61af8376ce4b52cd4020f5ce69a63
Reviewed-on: http://gerrit.cloudera.org:8080/5901
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/master/sys_catalog.cc
M src/kudu/master/sys_catalog.h
2 files changed, 74 insertions(+), 77 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7aa1e81ad7e61af8376ce4b52cd4020f5ce69a63
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [sys catalog] make visitor's code more generic

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5901

to look at the new patch set (#2).

Change subject: [sys_catalog] make visitor's code more generic
......................................................................

[sys_catalog] make visitor's code more generic

Minor refactoring on sys_catalog.{cc,h}: the visitor-related code
is made more generic to avoid code duplication.

There are no functional changes in this patch.

Change-Id: I7aa1e81ad7e61af8376ce4b52cd4020f5ce69a63
---
M src/kudu/master/sys_catalog.cc
M src/kudu/master/sys_catalog.h
2 files changed, 74 insertions(+), 77 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/5901/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7aa1e81ad7e61af8376ce4b52cd4020f5ce69a63
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>