You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2024/03/04 14:56:51 UTC
[PR] Better clarify excludeAll statement [incubator-pekko-sbt-paradox]
mdedetrich opened a new pull request, #129:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/129
Current wording is misleading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Better clarify excludeAll statement [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #129:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/129#discussion_r1511370469
##########
README.md:
##########
@@ -41,8 +41,8 @@ addSbtPlugin("org.apache.pekko" % "sbt-paradox-pekko" % "<version>")
> * sbt-paradox-apidoc
> * sbt-paradox-project-info
> you need to use an `excludesAll` statement on `addSbtPlugin` to remove the
-> JDK 11 reference, i.e. if you need to use sbt-site-paradox you would do the
-> following
+> resolved dependencies that rely on JDK 11+, i.e. if you need to use
+> * sbt-site-paradox you would do the following
Review Comment:
Thanks for pickup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Better clarify excludeAll statement [incubator-pekko-sbt-paradox]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #129:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/129#discussion_r1511338737
##########
README.md:
##########
@@ -41,8 +41,8 @@ addSbtPlugin("org.apache.pekko" % "sbt-paradox-pekko" % "<version>")
> * sbt-paradox-apidoc
> * sbt-paradox-project-info
> you need to use an `excludesAll` statement on `addSbtPlugin` to remove the
-> JDK 11 reference, i.e. if you need to use sbt-site-paradox you would do the
-> following
+> resolved dependencies that rely on JDK 11+, i.e. if you need to use
+> * sbt-site-paradox you would do the following
Review Comment:
wouldn't that `*` start a new bullet?
```suggestion
> sbt-site-paradox you would do the following
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Better clarify excludeAll statement [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #129:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/129#discussion_r1511371476
##########
README.md:
##########
@@ -41,8 +41,8 @@ addSbtPlugin("org.apache.pekko" % "sbt-paradox-pekko" % "<version>")
> * sbt-paradox-apidoc
> * sbt-paradox-project-info
> you need to use an `excludesAll` statement on `addSbtPlugin` to remove the
-> JDK 11 reference, i.e. if you need to use sbt-site-paradox you would do the
-> following
+> resolved dependencies that rely on JDK 11+, i.e. if you need to use
+> * sbt-site-paradox you would do the following
Review Comment:
Resolved + force pushed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Better clarify excludeAll statement [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #129:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org