You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/10/14 00:29:55 UTC

[GitHub] [hbase] Apache9 commented on a change in pull request #2540: HBASE-24628 Region normalizer now respects a rate limit (HMaster chore shutdown NPE ADDENDUM)

Apache9 commented on a change in pull request #2540:
URL: https://github.com/apache/hbase/pull/2540#discussion_r504332554



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1638,7 +1638,9 @@ private void stopChores() {
       choreService.cancelChore(this.mobFileCleanerChore);
       choreService.cancelChore(this.mobFileCompactionChore);
       choreService.cancelChore(this.balancerChore);
-      choreService.cancelChore(getRegionNormalizerManager().getRegionNormalizerChore());
+      Optional.ofNullable(this.regionNormalizerManager)

Review comment:
       Why not just use a null check?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org