You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by pu...@apache.org on 2019/03/06 08:00:52 UTC

[cordova-plugin-inappbrowser] branch master updated: Fix test spec.5 to close inappbrowser after loadstop event

This is an automated email from the ASF dual-hosted git repository.

purplecabbage pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-plugin-inappbrowser.git


The following commit(s) were added to refs/heads/master by this push:
     new 5f1afbd  Fix test spec.5 to close inappbrowser after loadstop event
     new af44235  Merge pull request #440 from cordova-develop/fix-close-event-test
5f1afbd is described below

commit 5f1afbdf05f7e882af4540292b2cfbb6f3755198
Author: KNaito <kn...@asial.co.jp>
AuthorDate: Wed Mar 6 11:47:21 2019 +0900

    Fix test spec.5 to close inappbrowser after loadstop event
---
 tests/tests.js | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/tests.js b/tests/tests.js
index 1a0619d..b4d2e68 100644
--- a/tests/tests.js
+++ b/tests/tests.js
@@ -136,8 +136,10 @@ exports.defineAutoTests = function () {
                     verifyEvent(evt, 'exit');
                     done();
                 });
-                iabInstance.close();
-                iabInstance = null;
+                iabInstance.addEventListener('loadstop', function (evt) {
+                    iabInstance.close();
+                    iabInstance = null;
+                });
             });
 
             it('inappbrowser.spec.6 should support loaderror event', function (done) {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org