You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Isuru Haththotuwa <is...@wso2.com> on 2014/01/16 18:47:50 UTC
Uniquely Identifying a LB Cartridge
Hi Devs,
Currently it seems that identifying a LB cartridge is done using a property
in cartridge definition ("name": "load.balancer", "value": "true"). The
Autoscaler looks at this to decide whether to assign a normal Cluster
Monitor or a LB Cluster Monitor. If this property is not available, there
is no way to do this. IMHO, we should not add this as a property, but as a
mandatory field. WDYT of adding a unique property to identify the LB
cartridge? Furthermore, we could extend this approach to uniquely identify
the four basic cartridge categories as previously discussed in the mail
thread with subject [1].
[1]. A Better Model for Generic Types of Cartridges
--
Thanks and Regards,
Isuru H.
+94 716 358 048* <http://wso2.com/>*
Re: Uniquely Identifying a LB Cartridge
Posted by Isuru Haththotuwa <is...@wso2.com>.
Sorry I couldn't reply to this earlier.
We have an abstraction for this purpose, and these four categories
(Application, Data, Framework and LB) are the currently identified concrete
implementations. So, the code is pretty much generic there, and we don't
have to use long if-else ladders in the program flow. As Damitha mentioned
in his reply as well, if there is a complete new cartridge category in the
future, there will be code changes, but having this abstraction will help
to integrate the new category easily.
On Thu, Jan 23, 2014 at 1:09 PM, damitha kumarage <da...@gmail.com>wrote:
> Hi,
>
>
>> Defining catridges/types & plugging them in should solely be at the
>>> discretion of the users who deploy the PaaS framework.
>>>
>>
> Existing cartridge types are defined encapsulating the knowledge we
> currently have on cartridge functionalities. If requirement arise for new
> cartridge types then AFAIK it is not possible to add that functionality to
> Stratos code without patching here and there(correct me if I'am wrong). In
> order to allow smooth integration of such types I guess we need to abstract
> out cartridge type functionalities in the code with proper design so that
> new types can be plugged in.
>
> Damitha
>
>
>
> --
> __________________________________________________________________
> Damitha Kumarage
> http://people.apache.org/
> __________________________________________________________________
>
--
Thanks and Regards,
Isuru H.
+94 716 358 048* <http://wso2.com/>*
Re: Uniquely Identifying a LB Cartridge
Posted by damitha kumarage <da...@gmail.com>.
Hi,
> Defining catridges/types & plugging them in should solely be at the
>> discretion of the users who deploy the PaaS framework.
>>
>
Existing cartridge types are defined encapsulating the knowledge we
currently have on cartridge functionalities. If requirement arise for new
cartridge types then AFAIK it is not possible to add that functionality to
Stratos code without patching here and there(correct me if I'am wrong). In
order to allow smooth integration of such types I guess we need to abstract
out cartridge type functionalities in the code with proper design so that
new types can be plugged in.
Damitha
--
__________________________________________________________________
Damitha Kumarage
http://people.apache.org/
__________________________________________________________________
Re: Uniquely Identifying a LB Cartridge
Posted by Afkham Azeez <af...@gmail.com>.
On Tue, Jan 21, 2014 at 8:59 AM, Lakmal Warusawithana <la...@wso2.com>wrote:
>
>
>
> On Tue, Jan 21, 2014 at 8:55 AM, Afkham Azeez <af...@gmail.com> wrote:
>
>>
>>
>>
>> On Tue, Jan 21, 2014 at 8:50 AM, Lakmal Warusawithana <la...@wso2.com>wrote:
>>
>>>
>>>
>>>
>>> On Tue, Jan 21, 2014 at 8:44 AM, Afkham Azeez <af...@gmail.com> wrote:
>>>
>>>>
>>>>
>>>>
>>>> On Tue, Jan 21, 2014 at 8:29 AM, Lakmal Warusawithana <la...@wso2.com>wrote:
>>>>
>>>>> Hi Azeez,
>>>>>
>>>>> I have mention the cartridge type in this thread previously, here i
>>>>> list again for your convenience.
>>>>>
>>>>>
>>>>> 1. Application Cartridge - (e.g wordpress, drupal .etc - which
>>>>> does not required external artifact repo)
>>>>> 2. Data cartridge (e.g. MySQL, Mongo .etc - which does not
>>>>> required external artifact repo)
>>>>> 3. Framework cartridge (e.g. PHP, Ruby, Node.js .etc - which
>>>>> required external artifact repo)
>>>>> 4. LB cartridge (e.g Stratos LB, HAProxy LB - which does not
>>>>> required external artifact repo)
>>>>>
>>>>> Based on these type, Front end and backend functionalities may change.
>>>>> for e.g. whether it required a artifact repo or not ..etc
>>>>>
>>>>>
>>>> It is fine to categorize cartridges for documentation purposes, but
>>>> does the Stratos framework need to have prior knowledge about these
>>>> cartridges? Do we have to change anything to introduce a new cartridge type?
>>>>
>>>>
>>>
>>> Yes, with the knowledge currently we have, all cartridges will fit into
>>> one of above categorize.
>>>
>>
>> Are these types hardcoded? Is there a way to easily introduce a new type
>> without any changes to the framework?
>>
>
>
> AFAIK, in current code yes. IsuruH please correct me if I am wrong. I
> agree we need to come with proper extension mechanism, which we need to
> figure out.
>
Yeah,
If there is code like, if(type == appCatridge) doSomething; if (type ==
dataCatridge) doSomethingElse; it is not good. Since Stratos is a PaaS
framework, ideally, it should not have a prerequisite knowledge about the
catridges. Defining catridges/types & plugging them in should solely be at
the discretion of the users who deploy the PaaS framework.
Re: Uniquely Identifying a LB Cartridge
Posted by Lakmal Warusawithana <la...@wso2.com>.
On Tue, Jan 21, 2014 at 8:55 AM, Afkham Azeez <af...@gmail.com> wrote:
>
>
>
> On Tue, Jan 21, 2014 at 8:50 AM, Lakmal Warusawithana <la...@wso2.com>wrote:
>
>>
>>
>>
>> On Tue, Jan 21, 2014 at 8:44 AM, Afkham Azeez <af...@gmail.com> wrote:
>>
>>>
>>>
>>>
>>> On Tue, Jan 21, 2014 at 8:29 AM, Lakmal Warusawithana <la...@wso2.com>wrote:
>>>
>>>> Hi Azeez,
>>>>
>>>> I have mention the cartridge type in this thread previously, here i
>>>> list again for your convenience.
>>>>
>>>>
>>>> 1. Application Cartridge - (e.g wordpress, drupal .etc - which does
>>>> not required external artifact repo)
>>>> 2. Data cartridge (e.g. MySQL, Mongo .etc - which does not required
>>>> external artifact repo)
>>>> 3. Framework cartridge (e.g. PHP, Ruby, Node.js .etc - which
>>>> required external artifact repo)
>>>> 4. LB cartridge (e.g Stratos LB, HAProxy LB - which does not
>>>> required external artifact repo)
>>>>
>>>> Based on these type, Front end and backend functionalities may change.
>>>> for e.g. whether it required a artifact repo or not ..etc
>>>>
>>>>
>>> It is fine to categorize cartridges for documentation purposes, but does
>>> the Stratos framework need to have prior knowledge about these cartridges?
>>> Do we have to change anything to introduce a new cartridge type?
>>>
>>>
>>
>> Yes, with the knowledge currently we have, all cartridges will fit into
>> one of above categorize.
>>
>
> Are these types hardcoded? Is there a way to easily introduce a new type
> without any changes to the framework?
>
AFAIK, in current code yes. IsuruH please correct me if I am wrong. I agree
we need to come with proper extension mechanism, which we need to figure
out.
--
Lakmal Warusawithana
Software Architect; WSO2 Inc.
Mobile : +94714289692
Blog : http://lakmalsview.blogspot.com/
Re: Uniquely Identifying a LB Cartridge
Posted by Afkham Azeez <af...@gmail.com>.
On Tue, Jan 21, 2014 at 8:50 AM, Lakmal Warusawithana <la...@wso2.com>wrote:
>
>
>
> On Tue, Jan 21, 2014 at 8:44 AM, Afkham Azeez <af...@gmail.com> wrote:
>
>>
>>
>>
>> On Tue, Jan 21, 2014 at 8:29 AM, Lakmal Warusawithana <la...@wso2.com>wrote:
>>
>>> Hi Azeez,
>>>
>>> I have mention the cartridge type in this thread previously, here i list
>>> again for your convenience.
>>>
>>>
>>> 1. Application Cartridge - (e.g wordpress, drupal .etc - which does
>>> not required external artifact repo)
>>> 2. Data cartridge (e.g. MySQL, Mongo .etc - which does not required
>>> external artifact repo)
>>> 3. Framework cartridge (e.g. PHP, Ruby, Node.js .etc - which
>>> required external artifact repo)
>>> 4. LB cartridge (e.g Stratos LB, HAProxy LB - which does not
>>> required external artifact repo)
>>>
>>> Based on these type, Front end and backend functionalities may change.
>>> for e.g. whether it required a artifact repo or not ..etc
>>>
>>>
>> It is fine to categorize cartridges for documentation purposes, but does
>> the Stratos framework need to have prior knowledge about these cartridges?
>> Do we have to change anything to introduce a new cartridge type?
>>
>>
>
> Yes, with the knowledge currently we have, all cartridges will fit into
> one of above categorize.
>
Are these types hardcoded? Is there a way to easily introduce a new type
without any changes to the framework?
Re: Uniquely Identifying a LB Cartridge
Posted by Lakmal Warusawithana <la...@wso2.com>.
On Tue, Jan 21, 2014 at 8:44 AM, Afkham Azeez <af...@gmail.com> wrote:
>
>
>
> On Tue, Jan 21, 2014 at 8:29 AM, Lakmal Warusawithana <la...@wso2.com>wrote:
>
>> Hi Azeez,
>>
>> I have mention the cartridge type in this thread previously, here i list
>> again for your convenience.
>>
>>
>> 1. Application Cartridge - (e.g wordpress, drupal .etc - which does
>> not required external artifact repo)
>> 2. Data cartridge (e.g. MySQL, Mongo .etc - which does not required
>> external artifact repo)
>> 3. Framework cartridge (e.g. PHP, Ruby, Node.js .etc - which required
>> external artifact repo)
>> 4. LB cartridge (e.g Stratos LB, HAProxy LB - which does not required
>> external artifact repo)
>>
>> Based on these type, Front end and backend functionalities may change.
>> for e.g. whether it required a artifact repo or not ..etc
>>
>>
> It is fine to categorize cartridges for documentation purposes, but does
> the Stratos framework need to have prior knowledge about these cartridges?
> Do we have to change anything to introduce a new cartridge type?
>
>
Yes, with the knowledge currently we have, all cartridges will fit into one
of above categorize.
>
>>
>> On Tue, Jan 21, 2014 at 8:14 AM, Afkham Azeez <af...@gmail.com> wrote:
>>
>>> Why is it necessary to classify the LB cartridge as a special cartridge?
>>> What are the other cartridge types available? Why do we need to specify
>>> cartridge types in the first place?
>>>
>>>
>>> On Thu, Jan 16, 2014 at 11:17 PM, Isuru Haththotuwa <is...@wso2.com>wrote:
>>>
>>>> Hi Devs,
>>>>
>>>>
>>>> Currently it seems that identifying a LB cartridge is done using a
>>>> property in cartridge definition ("name": "load.balancer", "value":
>>>> "true"). The Autoscaler looks at this to decide whether to assign a normal
>>>> Cluster Monitor or a LB Cluster Monitor. If this property is not available,
>>>> there is no way to do this. IMHO, we should not add this as a property, but
>>>> as a mandatory field. WDYT of adding a unique property to identify the LB
>>>> cartridge? Furthermore, we could extend this approach to uniquely identify
>>>> the four basic cartridge categories as previously discussed in the mail
>>>> thread with subject [1].
>>>>
>>>> [1]. A Better Model for Generic Types of Cartridges
>>>>
>>>>
>>>> --
>>>> Thanks and Regards,
>>>>
>>>> Isuru H.
>>>> +94 716 358 048* <http://wso2.com/>*
>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> *Afkham Azeez*
>>> Director of Architecture; WSO2, Inc.; http://wso2.com,
>>> *Member; Apache Software Foundation; **http://www.apache.org/*<http://www.apache.org/>
>>>
>>> *email: **azeez@wso2.com* <az...@wso2.com>
>>> * cell: +94 77 3320919 <%2B94%2077%203320919> blog: *
>>> *http://blog.afkham.org* <http://blog.afkham.org>
>>> *twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
>>> * linked-in: **http://lk.linkedin.com/in/afkhamazeez
>>> <http://lk.linkedin.com/in/afkhamazeez>*
>>>
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>
>>
>> --
>> Lakmal Warusawithana
>> Software Architect; WSO2 Inc.
>> Mobile : +94714289692
>> Blog : http://lakmalsview.blogspot.com/
>>
>>
>
>
> --
> *Afkham Azeez*
> Director of Architecture; WSO2, Inc.; http://wso2.com,
> *Member; Apache Software Foundation; **http://www.apache.org/*<http://www.apache.org/>
>
> *email: **azeez@wso2.com* <az...@wso2.com>
> * cell: +94 77 3320919 <%2B94%2077%203320919> blog: *
> *http://blog.afkham.org* <http://blog.afkham.org>
> *twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
> * linked-in: **http://lk.linkedin.com/in/afkhamazeez
> <http://lk.linkedin.com/in/afkhamazeez>*
>
> *Lean . Enterprise . Middleware*
>
>
--
Lakmal Warusawithana
Software Architect; WSO2 Inc.
Mobile : +94714289692
Blog : http://lakmalsview.blogspot.com/
Re: Uniquely Identifying a LB Cartridge
Posted by Afkham Azeez <af...@gmail.com>.
On Tue, Jan 21, 2014 at 8:29 AM, Lakmal Warusawithana <la...@wso2.com>wrote:
> Hi Azeez,
>
> I have mention the cartridge type in this thread previously, here i list
> again for your convenience.
>
>
> 1. Application Cartridge - (e.g wordpress, drupal .etc - which does
> not required external artifact repo)
> 2. Data cartridge (e.g. MySQL, Mongo .etc - which does not required
> external artifact repo)
> 3. Framework cartridge (e.g. PHP, Ruby, Node.js .etc - which required
> external artifact repo)
> 4. LB cartridge (e.g Stratos LB, HAProxy LB - which does not required
> external artifact repo)
>
> Based on these type, Front end and backend functionalities may change. for
> e.g. whether it required a artifact repo or not ..etc
>
>
It is fine to categorize cartridges for documentation purposes, but does
the Stratos framework need to have prior knowledge about these cartridges?
Do we have to change anything to introduce a new cartridge type?
>
>
> On Tue, Jan 21, 2014 at 8:14 AM, Afkham Azeez <af...@gmail.com> wrote:
>
>> Why is it necessary to classify the LB cartridge as a special cartridge?
>> What are the other cartridge types available? Why do we need to specify
>> cartridge types in the first place?
>>
>>
>> On Thu, Jan 16, 2014 at 11:17 PM, Isuru Haththotuwa <is...@wso2.com>wrote:
>>
>>> Hi Devs,
>>>
>>>
>>> Currently it seems that identifying a LB cartridge is done using a
>>> property in cartridge definition ("name": "load.balancer", "value":
>>> "true"). The Autoscaler looks at this to decide whether to assign a normal
>>> Cluster Monitor or a LB Cluster Monitor. If this property is not available,
>>> there is no way to do this. IMHO, we should not add this as a property, but
>>> as a mandatory field. WDYT of adding a unique property to identify the LB
>>> cartridge? Furthermore, we could extend this approach to uniquely identify
>>> the four basic cartridge categories as previously discussed in the mail
>>> thread with subject [1].
>>>
>>> [1]. A Better Model for Generic Types of Cartridges
>>>
>>>
>>> --
>>> Thanks and Regards,
>>>
>>> Isuru H.
>>> +94 716 358 048* <http://wso2.com/>*
>>>
>>>
>>>
>>
>>
>> --
>> *Afkham Azeez*
>> Director of Architecture; WSO2, Inc.; http://wso2.com,
>> *Member; Apache Software Foundation; **http://www.apache.org/*<http://www.apache.org/>
>>
>> *email: **azeez@wso2.com* <az...@wso2.com>
>> * cell: +94 77 3320919 <%2B94%2077%203320919> blog: *
>> *http://blog.afkham.org* <http://blog.afkham.org>
>> *twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
>> * linked-in: **http://lk.linkedin.com/in/afkhamazeez
>> <http://lk.linkedin.com/in/afkhamazeez>*
>>
>> *Lean . Enterprise . Middleware*
>>
>>
>
>
> --
> Lakmal Warusawithana
> Software Architect; WSO2 Inc.
> Mobile : +94714289692
> Blog : http://lakmalsview.blogspot.com/
>
>
--
*Afkham Azeez*
Director of Architecture; WSO2, Inc.; http://wso2.com,
*Member; Apache Software Foundation;
**http://www.apache.org/*<http://www.apache.org/>
*email: **azeez@wso2.com* <az...@wso2.com>
* cell: +94 77 3320919 blog: **http://blog.afkham.org*<http://blog.afkham.org>
*twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
* linked-in: **http://lk.linkedin.com/in/afkhamazeez
<http://lk.linkedin.com/in/afkhamazeez>*
*Lean . Enterprise . Middleware*
Re: Uniquely Identifying a LB Cartridge
Posted by Lakmal Warusawithana <la...@wso2.com>.
Hi Azeez,
I have mention the cartridge type in this thread previously, here i list
again for your convenience.
1. Application Cartridge - (e.g wordpress, drupal .etc - which does not
required external artifact repo)
2. Data cartridge (e.g. MySQL, Mongo .etc - which does not required
external artifact repo)
3. Framework cartridge (e.g. PHP, Ruby, Node.js .etc - which required
external artifact repo)
4. LB cartridge (e.g Stratos LB, HAProxy LB - which does not required
external artifact repo)
Based on these type, Front end and backend functionalities may change. for
e.g. whether it required a artifact repo or not ..etc
On Tue, Jan 21, 2014 at 8:14 AM, Afkham Azeez <af...@gmail.com> wrote:
> Why is it necessary to classify the LB cartridge as a special cartridge?
> What are the other cartridge types available? Why do we need to specify
> cartridge types in the first place?
>
>
> On Thu, Jan 16, 2014 at 11:17 PM, Isuru Haththotuwa <is...@wso2.com>wrote:
>
>> Hi Devs,
>>
>>
>> Currently it seems that identifying a LB cartridge is done using a
>> property in cartridge definition ("name": "load.balancer", "value":
>> "true"). The Autoscaler looks at this to decide whether to assign a normal
>> Cluster Monitor or a LB Cluster Monitor. If this property is not available,
>> there is no way to do this. IMHO, we should not add this as a property, but
>> as a mandatory field. WDYT of adding a unique property to identify the LB
>> cartridge? Furthermore, we could extend this approach to uniquely identify
>> the four basic cartridge categories as previously discussed in the mail
>> thread with subject [1].
>>
>> [1]. A Better Model for Generic Types of Cartridges
>>
>>
>> --
>> Thanks and Regards,
>>
>> Isuru H.
>> +94 716 358 048* <http://wso2.com/>*
>>
>>
>>
>
>
> --
> *Afkham Azeez*
> Director of Architecture; WSO2, Inc.; http://wso2.com,
> *Member; Apache Software Foundation; **http://www.apache.org/*<http://www.apache.org/>
>
> *email: **azeez@wso2.com* <az...@wso2.com>
> * cell: +94 77 3320919 <%2B94%2077%203320919> blog: *
> *http://blog.afkham.org* <http://blog.afkham.org>
> *twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
> * linked-in: **http://lk.linkedin.com/in/afkhamazeez
> <http://lk.linkedin.com/in/afkhamazeez>*
>
> *Lean . Enterprise . Middleware*
>
>
--
Lakmal Warusawithana
Software Architect; WSO2 Inc.
Mobile : +94714289692
Blog : http://lakmalsview.blogspot.com/
Re: Uniquely Identifying a LB Cartridge
Posted by Afkham Azeez <af...@gmail.com>.
Why is it necessary to classify the LB cartridge as a special cartridge?
What are the other cartridge types available? Why do we need to specify
cartridge types in the first place?
On Thu, Jan 16, 2014 at 11:17 PM, Isuru Haththotuwa <is...@wso2.com> wrote:
> Hi Devs,
>
>
> Currently it seems that identifying a LB cartridge is done using a
> property in cartridge definition ("name": "load.balancer", "value":
> "true"). The Autoscaler looks at this to decide whether to assign a normal
> Cluster Monitor or a LB Cluster Monitor. If this property is not available,
> there is no way to do this. IMHO, we should not add this as a property, but
> as a mandatory field. WDYT of adding a unique property to identify the LB
> cartridge? Furthermore, we could extend this approach to uniquely identify
> the four basic cartridge categories as previously discussed in the mail
> thread with subject [1].
>
> [1]. A Better Model for Generic Types of Cartridges
>
>
> --
> Thanks and Regards,
>
> Isuru H.
> +94 716 358 048* <http://wso2.com/>*
>
>
>
--
*Afkham Azeez*
Director of Architecture; WSO2, Inc.; http://wso2.com,
*Member; Apache Software Foundation;
**http://www.apache.org/*<http://www.apache.org/>
*email: **azeez@wso2.com* <az...@wso2.com>
* cell: +94 77 3320919 blog: **http://blog.afkham.org*<http://blog.afkham.org>
*twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
* linked-in: **http://lk.linkedin.com/in/afkhamazeez
<http://lk.linkedin.com/in/afkhamazeez>*
*Lean . Enterprise . Middleware*
Re: Uniquely Identifying a LB Cartridge
Posted by Udara Liyanage <ud...@wso2.com>.
+1 for cartridge category.
Touched, not typed. Erroneous words are a feature, not a typo.
On Jan 18, 2014 11:14 PM, "Isuru Haththotuwa" <is...@wso2.com> wrote:
> Great! Thanks everyone.
>
>
> On Sat, Jan 18, 2014 at 11:59 AM, Nirmal Fernando <ni...@gmail.com>wrote:
>
>> Ok, +1 for using a new element "category" and get rid of all unnecessary
>> attributes and properties.
>>
>>
>> On Sat, Jan 18, 2014 at 11:56 AM, Lakmal Warusawithana <la...@wso2.com>wrote:
>>
>>> Hi Nirnal,
>>>
>>> I think we can use "Cartridge Category" property to identify LB
>>> cartridge. That means we have 4 type of cartridges
>>>
>>> 1. Application Cartridge - (e.g wordpress, drupal .etc - which does
>>> not required external artifact repo)
>>> 2. Data cartridge (e.g. MySQL, Mongo .etc - which does not required
>>> external artifact repo)
>>> 3. Framework cartridge (e.g. PHP, Ruby, Node.js .etc - which
>>> required external artifact repo)
>>> 4. LB cartridge (e.g Stratos LB, HAProxy LB - which does not
>>> required external artifact repo)
>>>
>>> thanks
>>>
>>>
>>> On Sat, Jan 18, 2014 at 11:13 AM, Nirmal Fernando <
>>> nirmal070125@gmail.com> wrote:
>>>
>>>> To be clear, concern I raised was to the idea of creating elements in
>>>> order to recognize whether it's a lb Cartridge (eg: isLoadBalancer or
>>>> something). If we're to go this path we'll end up adding whole lot of
>>>> elements to the config, to detect whether it's a data Cartridge and so on.
>>>>
>>>> I'm +1 for defining a general property. But not sure how practical it
>>>> is.
>>>>
>>>>
>>>> On Sat, Jan 18, 2014 at 11:06 AM, Lahiru Sandaruwan <la...@wso2.com>wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Sent from my mobile.
>>>>>
>>>>> On Jan 17, 2014 1:18 PM, "damitha kumarage" <da...@gmail.com>
>>>>> wrote:
>>>>> >
>>>>> > Hi Nirmal,
>>>>> > IMHO it is not a bad idea to promote an optional property to a
>>>>> mandatory property if it is deemed such promotion is necessary. However
>>>>> such changes desired to be infrequent and can be allowed between major
>>>>> versions.
>>>>>
>>>>> +1. This is an important property. Specially when we have more
>>>>> cartridge types as Isuru mentioned. Then we can't check if it's there or
>>>>> not. We have to know which type is it.
>>>>> So +1 for mandating this.
>>>>>
>>>>> Thanks.
>>>>>
>>>>> >
>>>>> > Damitha
>>>>> >
>>>>> >
>>>>> > On Fri, Jan 17, 2014 at 8:49 AM, Nirmal Fernando <
>>>>> nirmal070125@gmail.com> wrote:
>>>>> >>
>>>>> >> Isuru,
>>>>> >>
>>>>> >> Problem I see here is, if we follow the same structure, we have to
>>>>> keep adding new elements to the configuration, which would make it complex
>>>>> to configure. So, IMO we should keep using properties (since these are
>>>>> optional elements) leveraging the extensibility of the Cartridge definition
>>>>> file and correctly document them all.
>>>>> >>
>>>>> >>
>>>>> >> On Thu, Jan 16, 2014 at 11:17 PM, Isuru Haththotuwa <
>>>>> isuruh@wso2.com> wrote:
>>>>> >>>
>>>>> >>> Hi Devs,
>>>>> >>>
>>>>> >>>
>>>>> >>> Currently it seems that identifying a LB cartridge is done using a
>>>>> property in cartridge definition ("name": "load.balancer", "value":
>>>>> "true"). The Autoscaler looks at this to decide whether to assign a normal
>>>>> Cluster Monitor or a LB Cluster Monitor. If this property is not available,
>>>>> there is no way to do this.
>>>>> >>
>>>>> >>
>>>>> >> Well, the logic should be corrected (if it's not already there) to
>>>>> assume the value of this property as false by default. So, if you didn't
>>>>> specify it explicitly, its value still be false.
>>>>> >>
>>>>> >>>
>>>>> >>> IMHO, we should not add this as a property, but as a mandatory
>>>>> field. WDYT of adding a unique property to identify the LB cartridge?
>>>>> Furthermore, we could extend this approach to uniquely identify the four
>>>>> basic cartridge categories as previously discussed in the mail thread with
>>>>> subject [1].
>>>>> >>>
>>>>> >>> [1]. A Better Model for Generic Types of Cartridges
>>>>> >>>
>>>>> >>>
>>>>> >>> --
>>>>> >>> Thanks and Regards,
>>>>> >>>
>>>>> >>> Isuru H.
>>>>> >>> +94 716 358 048
>>>>> >>>
>>>>> >>>
>>>>> >>
>>>>> >>
>>>>> >>
>>>>> >> --
>>>>> >> Best Regards,
>>>>> >> Nirmal
>>>>> >>
>>>>> >> Nirmal Fernando.
>>>>> >> PPMC Member & Committer of Apache Stratos,
>>>>> >> Senior Software Engineer, WSO2 Inc.
>>>>> >>
>>>>> >> Blog: http://nirmalfdo.blogspot.com/
>>>>> >
>>>>> >
>>>>> >
>>>>> >
>>>>> > --
>>>>> > __________________________________________________________________
>>>>> > Damitha Kumarage
>>>>> > http://people.apache.org/
>>>>> > __________________________________________________________________
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Best Regards,
>>>> Nirmal
>>>>
>>>> Nirmal Fernando.
>>>> PPMC Member & Committer of Apache Stratos,
>>>> Senior Software Engineer, WSO2 Inc.
>>>>
>>>> Blog: http://nirmalfdo.blogspot.com/
>>>>
>>>
>>>
>>>
>>> --
>>> Lakmal Warusawithana
>>> Software Architect; WSO2 Inc.
>>> Mobile : +94714289692
>>> Blog : http://lakmalsview.blogspot.com/
>>>
>>>
>>
>>
>> --
>> Best Regards,
>> Nirmal
>>
>> Nirmal Fernando.
>> PPMC Member & Committer of Apache Stratos,
>> Senior Software Engineer, WSO2 Inc.
>>
>> Blog: http://nirmalfdo.blogspot.com/
>>
>
>
>
> --
> Thanks and Regards,
>
> Isuru H.
> +94 716 358 048* <http://wso2.com/>*
>
>
>
Re: Uniquely Identifying a LB Cartridge
Posted by Isuru Haththotuwa <is...@wso2.com>.
Great! Thanks everyone.
On Sat, Jan 18, 2014 at 11:59 AM, Nirmal Fernando <ni...@gmail.com>wrote:
> Ok, +1 for using a new element "category" and get rid of all unnecessary
> attributes and properties.
>
>
> On Sat, Jan 18, 2014 at 11:56 AM, Lakmal Warusawithana <la...@wso2.com>wrote:
>
>> Hi Nirnal,
>>
>> I think we can use "Cartridge Category" property to identify LB
>> cartridge. That means we have 4 type of cartridges
>>
>> 1. Application Cartridge - (e.g wordpress, drupal .etc - which does
>> not required external artifact repo)
>> 2. Data cartridge (e.g. MySQL, Mongo .etc - which does not required
>> external artifact repo)
>> 3. Framework cartridge (e.g. PHP, Ruby, Node.js .etc - which required
>> external artifact repo)
>> 4. LB cartridge (e.g Stratos LB, HAProxy LB - which does not required
>> external artifact repo)
>>
>> thanks
>>
>>
>> On Sat, Jan 18, 2014 at 11:13 AM, Nirmal Fernando <nirmal070125@gmail.com
>> > wrote:
>>
>>> To be clear, concern I raised was to the idea of creating elements in
>>> order to recognize whether it's a lb Cartridge (eg: isLoadBalancer or
>>> something). If we're to go this path we'll end up adding whole lot of
>>> elements to the config, to detect whether it's a data Cartridge and so on.
>>>
>>> I'm +1 for defining a general property. But not sure how practical it is.
>>>
>>>
>>> On Sat, Jan 18, 2014 at 11:06 AM, Lahiru Sandaruwan <la...@wso2.com>wrote:
>>>
>>>> Hi,
>>>>
>>>> Sent from my mobile.
>>>>
>>>> On Jan 17, 2014 1:18 PM, "damitha kumarage" <da...@gmail.com>
>>>> wrote:
>>>> >
>>>> > Hi Nirmal,
>>>> > IMHO it is not a bad idea to promote an optional property to a
>>>> mandatory property if it is deemed such promotion is necessary. However
>>>> such changes desired to be infrequent and can be allowed between major
>>>> versions.
>>>>
>>>> +1. This is an important property. Specially when we have more
>>>> cartridge types as Isuru mentioned. Then we can't check if it's there or
>>>> not. We have to know which type is it.
>>>> So +1 for mandating this.
>>>>
>>>> Thanks.
>>>>
>>>> >
>>>> > Damitha
>>>> >
>>>> >
>>>> > On Fri, Jan 17, 2014 at 8:49 AM, Nirmal Fernando <
>>>> nirmal070125@gmail.com> wrote:
>>>> >>
>>>> >> Isuru,
>>>> >>
>>>> >> Problem I see here is, if we follow the same structure, we have to
>>>> keep adding new elements to the configuration, which would make it complex
>>>> to configure. So, IMO we should keep using properties (since these are
>>>> optional elements) leveraging the extensibility of the Cartridge definition
>>>> file and correctly document them all.
>>>> >>
>>>> >>
>>>> >> On Thu, Jan 16, 2014 at 11:17 PM, Isuru Haththotuwa <is...@wso2.com>
>>>> wrote:
>>>> >>>
>>>> >>> Hi Devs,
>>>> >>>
>>>> >>>
>>>> >>> Currently it seems that identifying a LB cartridge is done using a
>>>> property in cartridge definition ("name": "load.balancer", "value":
>>>> "true"). The Autoscaler looks at this to decide whether to assign a normal
>>>> Cluster Monitor or a LB Cluster Monitor. If this property is not available,
>>>> there is no way to do this.
>>>> >>
>>>> >>
>>>> >> Well, the logic should be corrected (if it's not already there) to
>>>> assume the value of this property as false by default. So, if you didn't
>>>> specify it explicitly, its value still be false.
>>>> >>
>>>> >>>
>>>> >>> IMHO, we should not add this as a property, but as a mandatory
>>>> field. WDYT of adding a unique property to identify the LB cartridge?
>>>> Furthermore, we could extend this approach to uniquely identify the four
>>>> basic cartridge categories as previously discussed in the mail thread with
>>>> subject [1].
>>>> >>>
>>>> >>> [1]. A Better Model for Generic Types of Cartridges
>>>> >>>
>>>> >>>
>>>> >>> --
>>>> >>> Thanks and Regards,
>>>> >>>
>>>> >>> Isuru H.
>>>> >>> +94 716 358 048
>>>> >>>
>>>> >>>
>>>> >>
>>>> >>
>>>> >>
>>>> >> --
>>>> >> Best Regards,
>>>> >> Nirmal
>>>> >>
>>>> >> Nirmal Fernando.
>>>> >> PPMC Member & Committer of Apache Stratos,
>>>> >> Senior Software Engineer, WSO2 Inc.
>>>> >>
>>>> >> Blog: http://nirmalfdo.blogspot.com/
>>>> >
>>>> >
>>>> >
>>>> >
>>>> > --
>>>> > __________________________________________________________________
>>>> > Damitha Kumarage
>>>> > http://people.apache.org/
>>>> > __________________________________________________________________
>>>>
>>>>
>>>
>>>
>>> --
>>> Best Regards,
>>> Nirmal
>>>
>>> Nirmal Fernando.
>>> PPMC Member & Committer of Apache Stratos,
>>> Senior Software Engineer, WSO2 Inc.
>>>
>>> Blog: http://nirmalfdo.blogspot.com/
>>>
>>
>>
>>
>> --
>> Lakmal Warusawithana
>> Software Architect; WSO2 Inc.
>> Mobile : +94714289692
>> Blog : http://lakmalsview.blogspot.com/
>>
>>
>
>
> --
> Best Regards,
> Nirmal
>
> Nirmal Fernando.
> PPMC Member & Committer of Apache Stratos,
> Senior Software Engineer, WSO2 Inc.
>
> Blog: http://nirmalfdo.blogspot.com/
>
--
Thanks and Regards,
Isuru H.
+94 716 358 048* <http://wso2.com/>*
Re: Uniquely Identifying a LB Cartridge
Posted by Nirmal Fernando <ni...@gmail.com>.
Ok, +1 for using a new element "category" and get rid of all unnecessary
attributes and properties.
On Sat, Jan 18, 2014 at 11:56 AM, Lakmal Warusawithana <la...@wso2.com>wrote:
> Hi Nirnal,
>
> I think we can use "Cartridge Category" property to identify LB cartridge.
> That means we have 4 type of cartridges
>
> 1. Application Cartridge - (e.g wordpress, drupal .etc - which does
> not required external artifact repo)
> 2. Data cartridge (e.g. MySQL, Mongo .etc - which does not required
> external artifact repo)
> 3. Framework cartridge (e.g. PHP, Ruby, Node.js .etc - which required
> external artifact repo)
> 4. LB cartridge (e.g Stratos LB, HAProxy LB - which does not required
> external artifact repo)
>
> thanks
>
>
> On Sat, Jan 18, 2014 at 11:13 AM, Nirmal Fernando <ni...@gmail.com>wrote:
>
>> To be clear, concern I raised was to the idea of creating elements in
>> order to recognize whether it's a lb Cartridge (eg: isLoadBalancer or
>> something). If we're to go this path we'll end up adding whole lot of
>> elements to the config, to detect whether it's a data Cartridge and so on.
>>
>> I'm +1 for defining a general property. But not sure how practical it is.
>>
>>
>> On Sat, Jan 18, 2014 at 11:06 AM, Lahiru Sandaruwan <la...@wso2.com>wrote:
>>
>>> Hi,
>>>
>>> Sent from my mobile.
>>>
>>> On Jan 17, 2014 1:18 PM, "damitha kumarage" <da...@gmail.com> wrote:
>>> >
>>> > Hi Nirmal,
>>> > IMHO it is not a bad idea to promote an optional property to a
>>> mandatory property if it is deemed such promotion is necessary. However
>>> such changes desired to be infrequent and can be allowed between major
>>> versions.
>>>
>>> +1. This is an important property. Specially when we have more cartridge
>>> types as Isuru mentioned. Then we can't check if it's there or not. We have
>>> to know which type is it.
>>> So +1 for mandating this.
>>>
>>> Thanks.
>>>
>>> >
>>> > Damitha
>>> >
>>> >
>>> > On Fri, Jan 17, 2014 at 8:49 AM, Nirmal Fernando <
>>> nirmal070125@gmail.com> wrote:
>>> >>
>>> >> Isuru,
>>> >>
>>> >> Problem I see here is, if we follow the same structure, we have to
>>> keep adding new elements to the configuration, which would make it complex
>>> to configure. So, IMO we should keep using properties (since these are
>>> optional elements) leveraging the extensibility of the Cartridge definition
>>> file and correctly document them all.
>>> >>
>>> >>
>>> >> On Thu, Jan 16, 2014 at 11:17 PM, Isuru Haththotuwa <is...@wso2.com>
>>> wrote:
>>> >>>
>>> >>> Hi Devs,
>>> >>>
>>> >>>
>>> >>> Currently it seems that identifying a LB cartridge is done using a
>>> property in cartridge definition ("name": "load.balancer", "value":
>>> "true"). The Autoscaler looks at this to decide whether to assign a normal
>>> Cluster Monitor or a LB Cluster Monitor. If this property is not available,
>>> there is no way to do this.
>>> >>
>>> >>
>>> >> Well, the logic should be corrected (if it's not already there) to
>>> assume the value of this property as false by default. So, if you didn't
>>> specify it explicitly, its value still be false.
>>> >>
>>> >>>
>>> >>> IMHO, we should not add this as a property, but as a mandatory
>>> field. WDYT of adding a unique property to identify the LB cartridge?
>>> Furthermore, we could extend this approach to uniquely identify the four
>>> basic cartridge categories as previously discussed in the mail thread with
>>> subject [1].
>>> >>>
>>> >>> [1]. A Better Model for Generic Types of Cartridges
>>> >>>
>>> >>>
>>> >>> --
>>> >>> Thanks and Regards,
>>> >>>
>>> >>> Isuru H.
>>> >>> +94 716 358 048
>>> >>>
>>> >>>
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> Best Regards,
>>> >> Nirmal
>>> >>
>>> >> Nirmal Fernando.
>>> >> PPMC Member & Committer of Apache Stratos,
>>> >> Senior Software Engineer, WSO2 Inc.
>>> >>
>>> >> Blog: http://nirmalfdo.blogspot.com/
>>> >
>>> >
>>> >
>>> >
>>> > --
>>> > __________________________________________________________________
>>> > Damitha Kumarage
>>> > http://people.apache.org/
>>> > __________________________________________________________________
>>>
>>>
>>
>>
>> --
>> Best Regards,
>> Nirmal
>>
>> Nirmal Fernando.
>> PPMC Member & Committer of Apache Stratos,
>> Senior Software Engineer, WSO2 Inc.
>>
>> Blog: http://nirmalfdo.blogspot.com/
>>
>
>
>
> --
> Lakmal Warusawithana
> Software Architect; WSO2 Inc.
> Mobile : +94714289692
> Blog : http://lakmalsview.blogspot.com/
>
>
--
Best Regards,
Nirmal
Nirmal Fernando.
PPMC Member & Committer of Apache Stratos,
Senior Software Engineer, WSO2 Inc.
Blog: http://nirmalfdo.blogspot.com/
Re: Uniquely Identifying a LB Cartridge
Posted by Imesh Gunaratne <im...@apache.org>.
+1 for the new property!
On Jan 18, 2014 1:27 AM, "Lakmal Warusawithana" <la...@wso2.com> wrote:
> Hi Nirnal,
>
> I think we can use "Cartridge Category" property to identify LB cartridge.
> That means we have 4 type of cartridges
>
> 1. Application Cartridge - (e.g wordpress, drupal .etc - which does
> not required external artifact repo)
> 2. Data cartridge (e.g. MySQL, Mongo .etc - which does not required
> external artifact repo)
> 3. Framework cartridge (e.g. PHP, Ruby, Node.js .etc - which required
> external artifact repo)
> 4. LB cartridge (e.g Stratos LB, HAProxy LB - which does not required
> external artifact repo)
>
> thanks
>
>
> On Sat, Jan 18, 2014 at 11:13 AM, Nirmal Fernando <ni...@gmail.com>wrote:
>
>> To be clear, concern I raised was to the idea of creating elements in
>> order to recognize whether it's a lb Cartridge (eg: isLoadBalancer or
>> something). If we're to go this path we'll end up adding whole lot of
>> elements to the config, to detect whether it's a data Cartridge and so on.
>>
>> I'm +1 for defining a general property. But not sure how practical it is.
>>
>>
>> On Sat, Jan 18, 2014 at 11:06 AM, Lahiru Sandaruwan <la...@wso2.com>wrote:
>>
>>> Hi,
>>>
>>> Sent from my mobile.
>>>
>>> On Jan 17, 2014 1:18 PM, "damitha kumarage" <da...@gmail.com> wrote:
>>> >
>>> > Hi Nirmal,
>>> > IMHO it is not a bad idea to promote an optional property to a
>>> mandatory property if it is deemed such promotion is necessary. However
>>> such changes desired to be infrequent and can be allowed between major
>>> versions.
>>>
>>> +1. This is an important property. Specially when we have more cartridge
>>> types as Isuru mentioned. Then we can't check if it's there or not. We have
>>> to know which type is it.
>>> So +1 for mandating this.
>>>
>>> Thanks.
>>>
>>> >
>>> > Damitha
>>> >
>>> >
>>> > On Fri, Jan 17, 2014 at 8:49 AM, Nirmal Fernando <
>>> nirmal070125@gmail.com> wrote:
>>> >>
>>> >> Isuru,
>>> >>
>>> >> Problem I see here is, if we follow the same structure, we have to
>>> keep adding new elements to the configuration, which would make it complex
>>> to configure. So, IMO we should keep using properties (since these are
>>> optional elements) leveraging the extensibility of the Cartridge definition
>>> file and correctly document them all.
>>> >>
>>> >>
>>> >> On Thu, Jan 16, 2014 at 11:17 PM, Isuru Haththotuwa <is...@wso2.com>
>>> wrote:
>>> >>>
>>> >>> Hi Devs,
>>> >>>
>>> >>>
>>> >>> Currently it seems that identifying a LB cartridge is done using a
>>> property in cartridge definition ("name": "load.balancer", "value":
>>> "true"). The Autoscaler looks at this to decide whether to assign a normal
>>> Cluster Monitor or a LB Cluster Monitor. If this property is not available,
>>> there is no way to do this.
>>> >>
>>> >>
>>> >> Well, the logic should be corrected (if it's not already there) to
>>> assume the value of this property as false by default. So, if you didn't
>>> specify it explicitly, its value still be false.
>>> >>
>>> >>>
>>> >>> IMHO, we should not add this as a property, but as a mandatory
>>> field. WDYT of adding a unique property to identify the LB cartridge?
>>> Furthermore, we could extend this approach to uniquely identify the four
>>> basic cartridge categories as previously discussed in the mail thread with
>>> subject [1].
>>> >>>
>>> >>> [1]. A Better Model for Generic Types of Cartridges
>>> >>>
>>> >>>
>>> >>> --
>>> >>> Thanks and Regards,
>>> >>>
>>> >>> Isuru H.
>>> >>> +94 716 358 048
>>> >>>
>>> >>>
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> Best Regards,
>>> >> Nirmal
>>> >>
>>> >> Nirmal Fernando.
>>> >> PPMC Member & Committer of Apache Stratos,
>>> >> Senior Software Engineer, WSO2 Inc.
>>> >>
>>> >> Blog: http://nirmalfdo.blogspot.com/
>>> >
>>> >
>>> >
>>> >
>>> > --
>>> > __________________________________________________________________
>>> > Damitha Kumarage
>>> > http://people.apache.org/
>>> > __________________________________________________________________
>>>
>>>
>>
>>
>> --
>> Best Regards,
>> Nirmal
>>
>> Nirmal Fernando.
>> PPMC Member & Committer of Apache Stratos,
>> Senior Software Engineer, WSO2 Inc.
>>
>> Blog: http://nirmalfdo.blogspot.com/
>>
>
>
>
> --
> Lakmal Warusawithana
> Software Architect; WSO2 Inc.
> Mobile : +94714289692
> Blog : http://lakmalsview.blogspot.com/
>
>
Re: Uniquely Identifying a LB Cartridge
Posted by Lakmal Warusawithana <la...@wso2.com>.
Hi Nirnal,
I think we can use "Cartridge Category" property to identify LB cartridge.
That means we have 4 type of cartridges
1. Application Cartridge - (e.g wordpress, drupal .etc - which does not
required external artifact repo)
2. Data cartridge (e.g. MySQL, Mongo .etc - which does not required
external artifact repo)
3. Framework cartridge (e.g. PHP, Ruby, Node.js .etc - which required
external artifact repo)
4. LB cartridge (e.g Stratos LB, HAProxy LB - which does not required
external artifact repo)
thanks
On Sat, Jan 18, 2014 at 11:13 AM, Nirmal Fernando <ni...@gmail.com>wrote:
> To be clear, concern I raised was to the idea of creating elements in
> order to recognize whether it's a lb Cartridge (eg: isLoadBalancer or
> something). If we're to go this path we'll end up adding whole lot of
> elements to the config, to detect whether it's a data Cartridge and so on.
>
> I'm +1 for defining a general property. But not sure how practical it is.
>
>
> On Sat, Jan 18, 2014 at 11:06 AM, Lahiru Sandaruwan <la...@wso2.com>wrote:
>
>> Hi,
>>
>> Sent from my mobile.
>>
>> On Jan 17, 2014 1:18 PM, "damitha kumarage" <da...@gmail.com> wrote:
>> >
>> > Hi Nirmal,
>> > IMHO it is not a bad idea to promote an optional property to a
>> mandatory property if it is deemed such promotion is necessary. However
>> such changes desired to be infrequent and can be allowed between major
>> versions.
>>
>> +1. This is an important property. Specially when we have more cartridge
>> types as Isuru mentioned. Then we can't check if it's there or not. We have
>> to know which type is it.
>> So +1 for mandating this.
>>
>> Thanks.
>>
>> >
>> > Damitha
>> >
>> >
>> > On Fri, Jan 17, 2014 at 8:49 AM, Nirmal Fernando <
>> nirmal070125@gmail.com> wrote:
>> >>
>> >> Isuru,
>> >>
>> >> Problem I see here is, if we follow the same structure, we have to
>> keep adding new elements to the configuration, which would make it complex
>> to configure. So, IMO we should keep using properties (since these are
>> optional elements) leveraging the extensibility of the Cartridge definition
>> file and correctly document them all.
>> >>
>> >>
>> >> On Thu, Jan 16, 2014 at 11:17 PM, Isuru Haththotuwa <is...@wso2.com>
>> wrote:
>> >>>
>> >>> Hi Devs,
>> >>>
>> >>>
>> >>> Currently it seems that identifying a LB cartridge is done using a
>> property in cartridge definition ("name": "load.balancer", "value":
>> "true"). The Autoscaler looks at this to decide whether to assign a normal
>> Cluster Monitor or a LB Cluster Monitor. If this property is not available,
>> there is no way to do this.
>> >>
>> >>
>> >> Well, the logic should be corrected (if it's not already there) to
>> assume the value of this property as false by default. So, if you didn't
>> specify it explicitly, its value still be false.
>> >>
>> >>>
>> >>> IMHO, we should not add this as a property, but as a mandatory field.
>> WDYT of adding a unique property to identify the LB cartridge? Furthermore,
>> we could extend this approach to uniquely identify the four basic cartridge
>> categories as previously discussed in the mail thread with subject [1].
>> >>>
>> >>> [1]. A Better Model for Generic Types of Cartridges
>> >>>
>> >>>
>> >>> --
>> >>> Thanks and Regards,
>> >>>
>> >>> Isuru H.
>> >>> +94 716 358 048
>> >>>
>> >>>
>> >>
>> >>
>> >>
>> >> --
>> >> Best Regards,
>> >> Nirmal
>> >>
>> >> Nirmal Fernando.
>> >> PPMC Member & Committer of Apache Stratos,
>> >> Senior Software Engineer, WSO2 Inc.
>> >>
>> >> Blog: http://nirmalfdo.blogspot.com/
>> >
>> >
>> >
>> >
>> > --
>> > __________________________________________________________________
>> > Damitha Kumarage
>> > http://people.apache.org/
>> > __________________________________________________________________
>>
>>
>
>
> --
> Best Regards,
> Nirmal
>
> Nirmal Fernando.
> PPMC Member & Committer of Apache Stratos,
> Senior Software Engineer, WSO2 Inc.
>
> Blog: http://nirmalfdo.blogspot.com/
>
--
Lakmal Warusawithana
Software Architect; WSO2 Inc.
Mobile : +94714289692
Blog : http://lakmalsview.blogspot.com/
Re: Uniquely Identifying a LB Cartridge
Posted by Nirmal Fernando <ni...@gmail.com>.
To be clear, concern I raised was to the idea of creating elements in order
to recognize whether it's a lb Cartridge (eg: isLoadBalancer or something).
If we're to go this path we'll end up adding whole lot of elements to the
config, to detect whether it's a data Cartridge and so on.
I'm +1 for defining a general property. But not sure how practical it is.
On Sat, Jan 18, 2014 at 11:06 AM, Lahiru Sandaruwan <la...@wso2.com>wrote:
> Hi,
>
> Sent from my mobile.
>
> On Jan 17, 2014 1:18 PM, "damitha kumarage" <da...@gmail.com> wrote:
> >
> > Hi Nirmal,
> > IMHO it is not a bad idea to promote an optional property to a mandatory
> property if it is deemed such promotion is necessary. However such changes
> desired to be infrequent and can be allowed between major versions.
>
> +1. This is an important property. Specially when we have more cartridge
> types as Isuru mentioned. Then we can't check if it's there or not. We have
> to know which type is it.
> So +1 for mandating this.
>
> Thanks.
>
> >
> > Damitha
> >
> >
> > On Fri, Jan 17, 2014 at 8:49 AM, Nirmal Fernando <ni...@gmail.com>
> wrote:
> >>
> >> Isuru,
> >>
> >> Problem I see here is, if we follow the same structure, we have to
> keep adding new elements to the configuration, which would make it complex
> to configure. So, IMO we should keep using properties (since these are
> optional elements) leveraging the extensibility of the Cartridge definition
> file and correctly document them all.
> >>
> >>
> >> On Thu, Jan 16, 2014 at 11:17 PM, Isuru Haththotuwa <is...@wso2.com>
> wrote:
> >>>
> >>> Hi Devs,
> >>>
> >>>
> >>> Currently it seems that identifying a LB cartridge is done using a
> property in cartridge definition ("name": "load.balancer", "value":
> "true"). The Autoscaler looks at this to decide whether to assign a normal
> Cluster Monitor or a LB Cluster Monitor. If this property is not available,
> there is no way to do this.
> >>
> >>
> >> Well, the logic should be corrected (if it's not already there) to
> assume the value of this property as false by default. So, if you didn't
> specify it explicitly, its value still be false.
> >>
> >>>
> >>> IMHO, we should not add this as a property, but as a mandatory field.
> WDYT of adding a unique property to identify the LB cartridge? Furthermore,
> we could extend this approach to uniquely identify the four basic cartridge
> categories as previously discussed in the mail thread with subject [1].
> >>>
> >>> [1]. A Better Model for Generic Types of Cartridges
> >>>
> >>>
> >>> --
> >>> Thanks and Regards,
> >>>
> >>> Isuru H.
> >>> +94 716 358 048
> >>>
> >>>
> >>
> >>
> >>
> >> --
> >> Best Regards,
> >> Nirmal
> >>
> >> Nirmal Fernando.
> >> PPMC Member & Committer of Apache Stratos,
> >> Senior Software Engineer, WSO2 Inc.
> >>
> >> Blog: http://nirmalfdo.blogspot.com/
> >
> >
> >
> >
> > --
> > __________________________________________________________________
> > Damitha Kumarage
> > http://people.apache.org/
> > __________________________________________________________________
>
>
--
Best Regards,
Nirmal
Nirmal Fernando.
PPMC Member & Committer of Apache Stratos,
Senior Software Engineer, WSO2 Inc.
Blog: http://nirmalfdo.blogspot.com/
Re: Uniquely Identifying a LB Cartridge
Posted by Lahiru Sandaruwan <la...@wso2.com>.
Hi,
Sent from my mobile.
On Jan 17, 2014 1:18 PM, "damitha kumarage" <da...@gmail.com> wrote:
>
> Hi Nirmal,
> IMHO it is not a bad idea to promote an optional property to a mandatory
property if it is deemed such promotion is necessary. However such changes
desired to be infrequent and can be allowed between major versions.
+1. This is an important property. Specially when we have more cartridge
types as Isuru mentioned. Then we can't check if it's there or not. We have
to know which type is it.
So +1 for mandating this.
Thanks.
>
> Damitha
>
>
> On Fri, Jan 17, 2014 at 8:49 AM, Nirmal Fernando <ni...@gmail.com>
wrote:
>>
>> Isuru,
>>
>> Problem I see here is, if we follow the same structure, we have to keep
adding new elements to the configuration, which would make it complex to
configure. So, IMO we should keep using properties (since these are
optional elements) leveraging the extensibility of the Cartridge definition
file and correctly document them all.
>>
>>
>> On Thu, Jan 16, 2014 at 11:17 PM, Isuru Haththotuwa <is...@wso2.com>
wrote:
>>>
>>> Hi Devs,
>>>
>>>
>>> Currently it seems that identifying a LB cartridge is done using a
property in cartridge definition ("name": "load.balancer", "value":
"true"). The Autoscaler looks at this to decide whether to assign a normal
Cluster Monitor or a LB Cluster Monitor. If this property is not available,
there is no way to do this.
>>
>>
>> Well, the logic should be corrected (if it's not already there) to
assume the value of this property as false by default. So, if you didn't
specify it explicitly, its value still be false.
>>
>>>
>>> IMHO, we should not add this as a property, but as a mandatory field.
WDYT of adding a unique property to identify the LB cartridge? Furthermore,
we could extend this approach to uniquely identify the four basic cartridge
categories as previously discussed in the mail thread with subject [1].
>>>
>>> [1]. A Better Model for Generic Types of Cartridges
>>>
>>>
>>> --
>>> Thanks and Regards,
>>>
>>> Isuru H.
>>> +94 716 358 048
>>>
>>>
>>
>>
>>
>> --
>> Best Regards,
>> Nirmal
>>
>> Nirmal Fernando.
>> PPMC Member & Committer of Apache Stratos,
>> Senior Software Engineer, WSO2 Inc.
>>
>> Blog: http://nirmalfdo.blogspot.com/
>
>
>
>
> --
> __________________________________________________________________
> Damitha Kumarage
> http://people.apache.org/
> __________________________________________________________________
Re: Uniquely Identifying a LB Cartridge
Posted by damitha kumarage <da...@gmail.com>.
Hi Nirmal,
IMHO it is not a bad idea to promote an optional property to a mandatory
property if it is deemed such promotion is necessary. However such changes
desired to be infrequent and can be allowed between major versions.
Damitha
On Fri, Jan 17, 2014 at 8:49 AM, Nirmal Fernando <ni...@gmail.com>wrote:
> Isuru,
>
> Problem I see here is, if we follow the same structure, we have to keep
> adding new elements to the configuration, which would make it complex to
> configure. So, IMO we should keep using properties (since these are
> optional elements) leveraging the extensibility of the Cartridge definition
> file and correctly document them all.
>
>
> On Thu, Jan 16, 2014 at 11:17 PM, Isuru Haththotuwa <is...@wso2.com>wrote:
>
>> Hi Devs,
>>
>>
>> Currently it seems that identifying a LB cartridge is done using a
>> property in cartridge definition ("name": "load.balancer", "value":
>> "true"). The Autoscaler looks at this to decide whether to assign a normal
>> Cluster Monitor or a LB Cluster Monitor. If this property is not available,
>> there is no way to do this.
>>
>
> Well, the logic should be corrected (if it's not already there) to assume
> the value of this property as false by default. So, if you didn't specify
> it explicitly, its value still be false.
>
>
>> IMHO, we should not add this as a property, but as a mandatory field.
>> WDYT of adding a unique property to identify the LB cartridge? Furthermore,
>> we could extend this approach to uniquely identify the four basic cartridge
>> categories as previously discussed in the mail thread with subject [1].
>>
>> [1]. A Better Model for Generic Types of Cartridges
>>
>>
>> --
>> Thanks and Regards,
>>
>> Isuru H.
>> +94 716 358 048* <http://wso2.com/>*
>>
>>
>>
>
>
> --
> Best Regards,
> Nirmal
>
> Nirmal Fernando.
> PPMC Member & Committer of Apache Stratos,
> Senior Software Engineer, WSO2 Inc.
>
> Blog: http://nirmalfdo.blogspot.com/
>
--
__________________________________________________________________
Damitha Kumarage
http://people.apache.org/
__________________________________________________________________
Re: Uniquely Identifying a LB Cartridge
Posted by Nirmal Fernando <ni...@gmail.com>.
Isuru,
Problem I see here is, if we follow the same structure, we have to keep
adding new elements to the configuration, which would make it complex to
configure. So, IMO we should keep using properties (since these are
optional elements) leveraging the extensibility of the Cartridge definition
file and correctly document them all.
On Thu, Jan 16, 2014 at 11:17 PM, Isuru Haththotuwa <is...@wso2.com> wrote:
> Hi Devs,
>
>
> Currently it seems that identifying a LB cartridge is done using a
> property in cartridge definition ("name": "load.balancer", "value":
> "true"). The Autoscaler looks at this to decide whether to assign a normal
> Cluster Monitor or a LB Cluster Monitor. If this property is not available,
> there is no way to do this.
>
Well, the logic should be corrected (if it's not already there) to assume
the value of this property as false by default. So, if you didn't specify
it explicitly, its value still be false.
> IMHO, we should not add this as a property, but as a mandatory field. WDYT
> of adding a unique property to identify the LB cartridge? Furthermore, we
> could extend this approach to uniquely identify the four basic cartridge
> categories as previously discussed in the mail thread with subject [1].
>
> [1]. A Better Model for Generic Types of Cartridges
>
>
> --
> Thanks and Regards,
>
> Isuru H.
> +94 716 358 048* <http://wso2.com/>*
>
>
>
--
Best Regards,
Nirmal
Nirmal Fernando.
PPMC Member & Committer of Apache Stratos,
Senior Software Engineer, WSO2 Inc.
Blog: http://nirmalfdo.blogspot.com/