You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/05 20:56:32 UTC

[GitHub] [kafka] jonhkr opened a new pull request #9256: Fix some Gradle deprecation warnings

jonhkr opened a new pull request #9256:
URL: https://github.com/apache/kafka/pull/9256


   - Use `implementation` instead of `compile`
   - Use `testImplementation` instead of `testCompile`
   - Use `testRuntimeOnly` instead of `testRuntime`
   - Use `Jar.archiveBaseName` instead of `Jar.baseName`
   - Use `Jar.archiveClassifier` instead of `Jar.classifier`
   - Use `Jar.archiveVersion` instead of `Jar.version`
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jonhkr commented on pull request #9256: Fix some Gradle deprecation warnings

Posted by GitBox <gi...@apache.org>.
jonhkr commented on pull request #9256:
URL: https://github.com/apache/kafka/pull/9256#issuecomment-687807680


   Hey @omkreddy @ijuma, would you mind taking a look into this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jonhkr commented on pull request #9256: Fix some Gradle deprecation warnings

Posted by GitBox <gi...@apache.org>.
jonhkr commented on pull request #9256:
URL: https://github.com/apache/kafka/pull/9256#issuecomment-689757461


   @ijuma Could you take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jonhkr commented on pull request #9256: Fix some Gradle deprecation warnings

Posted by GitBox <gi...@apache.org>.
jonhkr commented on pull request #9256:
URL: https://github.com/apache/kafka/pull/9256#issuecomment-687805835


   The generated poms changed a bit. 
   - Dependencies in the `compile` scope were moved to `runtime`.
   - Some dependencies were introduced (the ones that were previously exported by the `compile` configuration.)
   
   [poms.zip](https://github.com/apache/kafka/files/5179804/poms.zip)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jonhkr commented on pull request #9256: Fix some Gradle deprecation warnings

Posted by GitBox <gi...@apache.org>.
jonhkr commented on pull request #9256:
URL: https://github.com/apache/kafka/pull/9256#issuecomment-689072311


   @ijuma Yes, it was.
   I've updated the code to use the `api` configuration provided by the `java-library` plugin. This configuration has the same behaviour of the `compile` that was deprecated.
   
   Now the generated poms should look exactly as before.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9256: Fix some Gradle deprecation warnings

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9256:
URL: https://github.com/apache/kafka/pull/9256#issuecomment-688930298


   Thanks for the PR.
   
   > Dependencies in the compile scope were moved to runtime.
   
   This seems like an issue, no?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org