You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/08/16 03:14:18 UTC
Review Request 68375: WIP: Added missing encode. Needs tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68375/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
WIP: Added missing encode. Needs tests.
Diffs
-----
3rdparty/libprocess/src/http.cpp e9d439280a10c49e2ac7e0acfbb8f5934e0eb53b
Diff: https://reviews.apache.org/r/68375/diff/1/
Testing
-------
Just posting the last of the chain that currently passes on my machine (with a shorter path set for `$TMP`). Needs more tests and testing.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 68375: WIP: Added missing encode. Needs tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68375/#review207449
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68297', '68374', '68301', '68375']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2174/mesos-review-68375
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2174/mesos-review-68375/logs/mesos-tests.log):
```
I0816 23:23:56.474107 17444 hierarchical.cpp:359] Removed framework 2530ee95-1553-4826-b987-78d955ac83fb-0000
I0816 23:23:56.475224 17444 hierarchical.cpp:795] Agent 2530ee95-1553-4826-b987-78d955ac83fb-S0 deactivated
I0816 23:23:56.476117 13872 containerizer.cpp:2407] Destroying container 877b607d-7f4d-4e66-9b06-c7a9e469aa9c in RUNNING state
I0816 23:23:56.476117 13872 containerizer.cpp:3021] Transitioning the state of container 877b607d-7f4d-4e66-9b06-c7a9e469aa9c from RUNNING to DESTROYING
I0816 23:23:56.477295 13872 launcher.cpp:155] Asked to destroy container 877b607d-7f4d-4e66-9b06-c7a9e469aa9c
I0816 23:23:56.483104 5728 containerizer.cpp:2860] Container 877b607d-7f4d-4e66-9b06-c7a9e469aa9c has exited
I0816 23:23:56.513223 17256 master.cpp:1093] Master terminating
I0816 23:23:56.514103 15636 hierarchical.cpp:637] Removed agent 2530e[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (588 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (608 ms total)
[----------] Global test environment tear-down
[==========] 1029 tests from 101 test cases ran. (559422 ms total)
[ PASSED ] 1020 tests.
[ FAILED ] 9 tests, listed below:
[ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "mesos"
[ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "docker,mesos"
[ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos"
9 FAILED TESTS
YOU HAVE 222 DISABLED TESTS
e95-1553-4826-b987-78d955ac83fb-S0
I0816 23:23:56.813189 16676 process.cpp:926] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Aug. 16, 2018, 3:14 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68375/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2018, 3:14 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> WIP: Added missing encode. Needs tests.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/http.cpp e9d439280a10c49e2ac7e0acfbb8f5934e0eb53b
>
>
> Diff: https://reviews.apache.org/r/68375/diff/1/
>
>
> Testing
> -------
>
> Just posting the last of the chain that currently passes on my machine (with a shorter path set for `$TMP`). Needs more tests and testing.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 68375: Fixed encoding behavior of
`http::internal::encode(Request)`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68375/#review207770
-----------------------------------------------------------
Ship it!
Note that at some point we'll also have to escape path segments, fragments, etc. E.g.
https://github.com/golang/go/blob/64f3d75bc288679e9e18cb9513897e7139f3fc3b/src/net/url/url.go#L96-L176
For now, this looks correct since query escaping seems to require all reserved characters to be escaped. However, it will unnecessarily escape some characters in the "unsafe" set from what I can tell.
- Benjamin Mahler
On Aug. 18, 2018, 1:19 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68375/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2018, 1:19 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-9168
> https://issues.apache.org/jira/browse/MESOS-9168
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed encoding behavior of `http::internal::encode(Request)`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/http.cpp e9d439280a10c49e2ac7e0acfbb8f5934e0eb53b
>
>
> Diff: https://reviews.apache.org/r/68375/diff/2/
>
>
> Testing
> -------
>
> Just posting the last of the chain that currently passes on my machine (with a shorter path set for `$TMP`). Needs more tests and testing.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 68375: Fixed encoding behavior of
`http::internal::encode(Request)`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68375/
-----------------------------------------------------------
(Updated Aug. 17, 2018, 6:19 p.m.)
Review request for mesos and Benjamin Mahler.
Summary (updated)
-----------------
Fixed encoding behavior of `http::internal::encode(Request)`.
Repository: mesos
Description (updated)
-------
Fixed encoding behavior of `http::internal::encode(Request)`.
Diffs (updated)
-----
3rdparty/libprocess/src/http.cpp e9d439280a10c49e2ac7e0acfbb8f5934e0eb53b
Diff: https://reviews.apache.org/r/68375/diff/2/
Changes: https://reviews.apache.org/r/68375/diff/1-2/
Testing
-------
Just posting the last of the chain that currently passes on my machine (with a shorter path set for `$TMP`). Needs more tests and testing.
Thanks,
Andrew Schwartzmeyer