[GitHub] [doris] mrhhsg commented on a diff in pull request #20050: [Bug](hash-join) fix hash join share hash map result not stable

["mrhhsg (via GitHub)" <gi...@apache.org>]

mrhhsg commented on code in PR #20050:
URL: https://github.com/apache/doris/pull/20050#discussion_r1205114720


##########
be/src/vec/exec/join/vhash_join_node.cpp:
##########
@@ -791,11 +791,10 @@ Status HashJoinNode::_materialize_build_side(RuntimeState* state) {
 
             RETURN_IF_ERROR(sink(state, &block, eos));
         }
-        RETURN_IF_ERROR(child(1)->close(state));
     } else {
-        RETURN_IF_ERROR(child(1)->close(state));
         RETURN_IF_ERROR(sink(state, nullptr, true));
     }
+    RETURN_IF_ERROR(child(1)->close(state));

Review Comment:
   this change will make child(1) close after `sink`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org