You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/12/10 23:31:41 UTC
[GitHub] [samza] cameronlee314 commented on a change in pull request #1229:
Adding internal config to retain non-logged stores on container start
cameronlee314 commented on a change in pull request #1229: Adding internal config to retain non-logged stores on container start
URL: https://github.com/apache/samza/pull/1229#discussion_r356334175
##########
File path: samza-core/src/main/java/org/apache/samza/storage/NonTransactionalStateTaskRestoreManager.java
##########
@@ -132,7 +132,7 @@ private void cleanBaseDirsAndReadOffsetFiles() {
storageManagerUtil.getTaskStoreDir(nonLoggedStoreBaseDirectory, storeName, taskModel.getTaskName(), taskModel.getTaskMode());
LOG.info("Got non logged storage partition directory as " + nonLoggedStorePartitionDir.toPath().toString());
- if (nonLoggedStorePartitionDir.exists()) {
+ if (nonLoggedStorePartitionDir.exists() || !storageConfig.getRetainNonloggedStoreDirsOnStart(storeName)) {
Review comment:
Should this be `&&` instead of `||`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services