[jira] [Commented] (CRUNCH-123) HBaseTarget should support PCollection

["Josh Wills (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CRUNCH-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510035#comment-13510035 ] 

Josh Wills commented on CRUNCH-123:
-----------------------------------

Micah, thanks for this, the patch looks great. I'm going to run it through the integration tests w/crunch.platform=1 and crunch.platform=2 and then commit it.
                
> HBaseTarget should support PCollection<Delete>
> ----------------------------------------------
>
>                 Key: CRUNCH-123
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-123
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Micah Whitacre
>            Assignee: Josh Wills
>         Attachments: crunch-123.patch
>
>
> Currently the HBaseTarget implementation does not accept PCollection<Delete> because of the following code in HBaseTarget.
> {quote}
> @Override
>   public boolean accept(OutputHandler handler, PType<?> ptype) {
>     if (Put.class.equals(ptype.getTypeClass())) {
>       handler.configure(this, ptype);
>       return true;
>     }
>     return false;
>   }
> {quote}
> The TableOutputFormat supports deletes so it seems like a change to the if statement to check if the ptype.getTypeClass() equals Delete.class is all that is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira