[GitHub] [spark] LuciferYang commented on a change in pull request #35310: [SPARK-38014][SQL][TESTS] Add Parquet Data Page V2 write scenario for `BuiltInDataSourceWriteBenchmark`

[GitBox <gi...@apache.org>]

LuciferYang commented on a change in pull request #35310:
URL: https://github.com/apache/spark/pull/35310#discussion_r797354430



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/BuiltInDataSourceWriteBenchmark.scala
##########
@@ -53,7 +56,16 @@ object BuiltInDataSourceWriteBenchmark extends DataSourceWriteBenchmark {
 
     formats.foreach { format =>
       runBenchmark(s"$format writer benchmark") {
-        runDataSourceBenchmark(format)
+        if (format.equals("Parquet")) {
+          ParquetProperties.WriterVersion.values().zip(Seq("V1", "V2")).foreach {

Review comment:
       ok, I will fix this later




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org