[jira] [Commented] (NIFI-5155) Bulletins do not include IP/hostname information

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505506#comment-16505506 ] 

ASF GitHub Bot commented on NIFI-5155:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/2773

    NIFI-5155: Add host address info to bulletins

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-5155

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2773.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2773
    
----
commit 2780f0218f60213ca6e85a32566d470cd51139fc
Author: Matthew Burgess <ma...@...>
Date:   2018-06-07T23:37:19Z

    NIFI-5155: Add host address info to bulletins

----


> Bulletins do not include IP/hostname information
> ------------------------------------------------
>
>                 Key: NIFI-5155
>                 URL: https://issues.apache.org/jira/browse/NIFI-5155
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>            Priority: Major
>
> There is an API call on Bulletin for setNodeAddress(), which is meant to set the node on which a bulletin/error has occurred. The SiteToSiteBulletinReportingTask uses getNodeAddress() to add said field to the outgoing records (if available). However, the framework is not calling setNodeAddress() anywhere, which results in the field being missing from the outgoing records.
> NiFi should add the appropriate node address information to the outgoing bulletin information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)