You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/06/06 21:41:49 UTC
[GitHub] [pinot] LaroLuo opened a new issue, #8842: Table selector won't work if table name is null
LaroLuo opened a new issue, #8842:
URL: https://github.com/apache/pinot/issues/8842
https://github.com/apache/pinot/blob/d1d2ddbc116f6dddbefdf1e69dd409434eaae0e4/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java#L86-L94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #8842: Table selector won't work if table name is null
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #8842:
URL: https://github.com/apache/pinot/issues/8842#issuecomment-1149330398
Thanks for reporting the issue.
If table name is not provided, we should parse the query and extract the table name from the query. This requires pulling in the `CalciteSqlParser` class, which is currently in `pinot-common` module.
We can either:
- Make `pinot-client` depend on `pinot-common`
- Pull `CalciteSqlParser` into `pinot-spi`
cc @xiangfu0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] npawar commented on issue #8842: Table selector won't work if table name is null
Posted by GitBox <gi...@apache.org>.
npawar commented on issue #8842:
URL: https://github.com/apache/pinot/issues/8842#issuecomment-1154482832
Assuming we are okay with these dependencies in pinot-client @xiangfu0 , labeling this as beginner as it looks straightforward enough to fix. Lmk if it is not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] Table selector won't work if table name is null [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #8842:
URL: https://github.com/apache/pinot/issues/8842#issuecomment-1762061809
Solved with #9902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] tanmesh commented on issue #8842: Table selector won't work if table name is null
Posted by GitBox <gi...@apache.org>.
tanmesh commented on issue #8842:
URL: https://github.com/apache/pinot/issues/8842#issuecomment-1221620201
I am planning to pick this up making the `pinot-client depend on pinot-common`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] Table selector won't work if table name is null [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang closed issue #8842: Table selector won't work if table name is null
URL: https://github.com/apache/pinot/issues/8842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] tanmesh commented on issue #8842: Table selector won't work if table name is null
Posted by GitBox <gi...@apache.org>.
tanmesh commented on issue #8842:
URL: https://github.com/apache/pinot/issues/8842#issuecomment-1221662572
Hey @npawar @Jackie-Jiang 👋 , can you please assign someone to review this PR 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on issue #8842: Table selector won't work if table name is null
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on issue #8842:
URL: https://github.com/apache/pinot/issues/8842#issuecomment-1223320851
The PR is on the right track.
One thing worth mentioning is that the get table name is the best effort.
And if the tableName is null, the brokerSelector should return any broker. E.g. `select 1` is usually used for testing the db connection by many external systems. This kind of query has no table name, but also a valid query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] tanmesh commented on issue #8842: Table selector won't work if table name is null
Posted by GitBox <gi...@apache.org>.
tanmesh commented on issue #8842:
URL: https://github.com/apache/pinot/issues/8842#issuecomment-1221390826
I am planning to pick up this task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org