[jira] Assigned: (WINK-102) Changes to FlushResultHandler

["Bryant Luk (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WINK-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryant Luk reassigned WINK-102:
-------------------------------

    Assignee: Bryant Luk

I'll go ahead and make these changes as well except for the logging ones.  I'll use a different issue to clean up the logging since it's probably better to be consistent across all methods on printStackTrace(), logging levels, etc.

> Changes to FlushResultHandler
> -----------------------------
>
>                 Key: WINK-102
>                 URL: https://issues.apache.org/jira/browse/WINK-102
>             Project: Wink
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 0.1
>            Reporter: Bryant Luk
>            Assignee: Bryant Luk
>
> 3 changes I think should be made for FlushResultHandler:
> 1)  I forgot about FlushHeadersOutputStream should override OutputStream.close().
> 2)  The FlushHeadersOutputStream's flushHeaders should be called directly after the MessageBodyWriter.writeTo is called and the DataContentHandler.writeTo.  The MessageBodyWriter is not guaranteed to write anything to the output stream but could just be pushing headers out (i.e. some headers to real content).
> 3)  The logger.warn() and logger.error() should be turned into an Info.  I don't think there's any reason to do repeated warnings to an administrator.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.