You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/23 07:15:43 UTC
[GitHub] [pulsar] MarvinCai opened a new pull request #9681: [Doc]Update document to indicating effect of negative acking message for order sube type like exclusive, failover and key_shared.
MarvinCai opened a new pull request #9681:
URL: https://github.com/apache/pulsar/pull/9681
Fixes #9582
### Motivation
Originally try to disable negative acknowledgement for Key_Shared, but after discussion it's more like document problem that user should be aware that negative acks are going to trigger the out of order delivery of a particular message.
### Modifications
Update document for negative acknowledgement to warn user that it might break message ordering.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #9681: [Doc]Update document to indicating effect of negative acking message for order sube type like exclusive, failover and key_shared.
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #9681:
URL: https://github.com/apache/pulsar/pull/9681
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #9681: [Doc]Update document to indicating effect of negative acking message for order sube type like exclusive, failover and key_shared.
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #9681:
URL: https://github.com/apache/pulsar/pull/9681#discussion_r582152944
##########
File path: site2/docs/concepts-messaging.md
##########
@@ -128,6 +128,8 @@ In the exclusive and failover subscription modes, consumers only negatively ackn
In the shared and Key_Shared subscription modes, you can negatively acknowledge messages individually.
+Be aware that doing negative ack on ordered subscription type like Exclusive, Failover and Key_Share can cause failed messages arrive consumer out of original order.
Review comment:
The same name is in many other places in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on a change in pull request #9681: [Doc]Update document to indicating effect of negative acking message for order sube type like exclusive, failover and key_shared.
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on a change in pull request #9681:
URL: https://github.com/apache/pulsar/pull/9681#discussion_r582286066
##########
File path: site2/docs/concepts-messaging.md
##########
@@ -128,6 +128,8 @@ In the exclusive and failover subscription modes, consumers only negatively ackn
In the shared and Key_Shared subscription modes, you can negatively acknowledge messages individually.
+Be aware that doing negative ack on ordered subscription type like Exclusive, Failover and Key_Share can cause failed messages arrive consumer out of original order.
Review comment:
fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #9681: [Doc]Update document to indicating effect of negative acking message for order sube type like exclusive, failover and key_shared.
Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #9681:
URL: https://github.com/apache/pulsar/pull/9681
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #9681: [Doc]Update document to indicating effect of negative acking message for order sube type like exclusive, failover and key_shared.
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #9681:
URL: https://github.com/apache/pulsar/pull/9681#discussion_r582152388
##########
File path: site2/docs/concepts-messaging.md
##########
@@ -128,6 +128,8 @@ In the exclusive and failover subscription modes, consumers only negatively ackn
In the shared and Key_Shared subscription modes, you can negatively acknowledge messages individually.
+Be aware that doing negative ack on ordered subscription type like Exclusive, Failover and Key_Share can cause failed messages arrive consumer out of original order.
Review comment:
`Key_Share` --> `Key_Shared`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #9681: [Doc]Update document to indicating effect of negative acking message for order sube type like exclusive, failover and key_shared.
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on a change in pull request #9681:
URL: https://github.com/apache/pulsar/pull/9681#discussion_r581693741
##########
File path: site2/docs/concepts-messaging.md
##########
@@ -128,6 +128,8 @@ In the exclusive and failover subscription modes, consumers only negatively ackn
In the shared and Key_Shared subscription modes, you can negatively acknowledge messages individually.
+Be aware that doing negative ack on ordered subscription type like Exclusive, Failover and Key_Share can cause failed messages arrive consumer out of original order.
Review comment:
```suggestion
Be aware that negative acknowledgment on ordered subscription types, such as Exclusive, Failover, and Key_Share, can cause failed messages to arrive consumers out of the original order.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org