You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/01/22 10:28:20 UTC

[GitHub] [incubator-eventmesh] ruanwenjun opened a new pull request #738: [ISSUE #737] Add Netty license

ruanwenjun opened a new pull request #738:
URL: https://github.com/apache/incubator-eventmesh/pull/738


   Fixes ISSUE #737
   
   ### Motivation
   
   * Add license files.
   
   
   
   ### Documentation
   
   - Does this pull request introduce a new feature? no
   - If yes, how is the feature documented? not applicable
   - If a feature is not applicable for documentation, explain why?
   - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #738: [ISSUE #737] Add Netty license

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #738:
URL: https://github.com/apache/incubator-eventmesh/pull/738#issuecomment-1019171065


   @xwm1992 @Shoothzj @pjfanning Take a look? If you are interested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #738: [ISSUE #737] Add Netty license

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #738:
URL: https://github.com/apache/incubator-eventmesh/pull/738#issuecomment-1019736190


   > I have recognized add a lot sub dependencies of `netty` in project, do we need all these sub dependencies now? @ruanwenjun @Shoothzj
   
   I think there are some binary dependencies we don't need, e.g. `netty-codec-redis`, `netty-codec-dns`, I am not sure, need to be careful when deleting. Currently, we need to add the missing LICENSE file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] Shoothzj commented on pull request #738: [ISSUE #737] Add Netty license

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #738:
URL: https://github.com/apache/incubator-eventmesh/pull/738#issuecomment-1019755429


   @ruanwenjun If we don't need, I suggest implement these module separately, I can work on this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #738: [ISSUE #737] Add Netty license

Posted by GitBox <gi...@apache.org>.
xwm1992 commented on pull request #738:
URL: https://github.com/apache/incubator-eventmesh/pull/738#issuecomment-1019664317


   I have recognized add a lot sub dependencies of `netty` in project, do we need all these sub dependencies now?
   @ruanwenjun @Shoothzj 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #738: [ISSUE #737] Add Netty license

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #738:
URL: https://github.com/apache/incubator-eventmesh/pull/738#issuecomment-1021100825


   > @ruanwenjun If we don't need, I suggest implement these module separately, I can work on this
   
   Great, you can open a new issue to optimize the dependency.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #738: [ISSUE #737] Add Netty license

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #738:
URL: https://github.com/apache/incubator-eventmesh/pull/738#issuecomment-1021100825


   > @ruanwenjun If we don't need, I suggest implement these module separately, I can work on this
   
   Great, you can open a new issue to optimize the dependency.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] xwm1992 merged pull request #738: [ISSUE #737] Add Netty license

Posted by GitBox <gi...@apache.org>.
xwm1992 merged pull request #738:
URL: https://github.com/apache/incubator-eventmesh/pull/738


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org