You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampipes.apache.org by "flomickl (via GitHub)" <gi...@apache.org> on 2023/02/25 20:11:28 UTC
[I] requiredMultiValueSelection allows zero selection and leads to error during execution (streampipes)
flomickl opened a new issue, #1351:
URL: https://github.com/apache/streampipes/issues/1351
### Body
I implemented a requiredMultiValueSelection in my declaireMethoth.
It is working as expected but it allows, that no value is selected.
```
.requiredMultiValueSelection(
Labels.withId(VALIDATION_TYPE_KEY),
Options.from(
ValidationType.IsEmpty.name(),
ValidationType.IsSimple.name()
)
)
```
**What I expect.**
Select one or two of these options
It should check if at least one field is selected.
**What happens.**
I can finish the Pipeline and no value is selected.
Pipeline is valid
But starts to fail of course
### StreamPipes Committer
I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] requiredMultiValueSelection allows zero selection and leads to error during execution (streampipes)
Posted by "flomickl (via GitHub)" <gi...@apache.org>.
flomickl commented on issue #1351:
URL: https://github.com/apache/streampipes/issues/1351#issuecomment-1452492013
Hm, what is the purpose and use case that a required input allows a non-selection?
So far this is the only example I know of where this is possible. So in the Processor it has to be intercepted extra if the List size is 0.
For example, with requiredText it is not possible for the user to allow an empty string as input.
In my eyes MultiValueSelection is the extension of SingleValueSelection and also here it is not allowed to have no selection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] requiredMultiValueSelection allows zero selection and leads to error during execution (streampipes)
Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer commented on issue #1351:
URL: https://github.com/apache/streampipes/issues/1351#issuecomment-1446937644
What is the supposed behaviour? I think checkbox groups generally don't forbid that no value at all and I'm pretty sure we also have some of these configuration in StreamPipes.
So does it make sense to add an option here that needs to be set in case at least one item needs to be selected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] requiredMultiValueSelection allows zero selection and leads to error during execution (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1351:
URL: https://github.com/apache/streampipes/issues/1351#issuecomment-1452500302
I think the name is just not really reflecting the components behavior.
It was probably chosen due to consistency wither the other components
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] requiredMultiValueSelection allows zero selection and leads to error during execution (streampipes)
Posted by "flomickl (via GitHub)" <gi...@apache.org>.
flomickl commented on issue #1351:
URL: https://github.com/apache/streampipes/issues/1351#issuecomment-1452546096
I solved the issue above with this kind of workaround in https://github.com/apache/streampipes/pull/1320/commits/5938bc96fa33745f288782d30401b74c71992b39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] requiredMultiValueSelection allows zero selection and leads to error during execution (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1351:
URL: https://github.com/apache/streampipes/issues/1351#issuecomment-1446986956
I agree, if I would like to request a single selection I would choose radio buttons as UI element.
But the naming of `requiredMultiValueSelection` is misleading though, right?
So adding a parameter that allows to enforce _at least one_ selection sounds like a good idea to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] requiredMultiValueSelection allows zero selection and leads to error during execution (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1351:
URL: https://github.com/apache/streampipes/issues/1351#issuecomment-1452511317
But I think it would be great to add support for a minimum amount of selected options 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org