You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rerngvit <gi...@git.apache.org> on 2016/07/19 14:52:38 UTC

[GitHub] spark pull request #14264: [SPARK-11976][SPARKR] Support "." character in Da...

GitHub user rerngvit opened a pull request:

    https://github.com/apache/spark/pull/14264

     [SPARK-11976][SPARKR] Support "." character in DataFrame column name

        ## What changes were proposed in this pull request?
        - Add support "." character in DataFrame column name
        - Remove R code in "createDataFrame()" that replaces "." with "_"
        - Remove warning suppression in createDataFrame() for iris dataset (introduced in SPARK-12034)
    
        ## How was this patch tested?
        SparkR unit tests and manual testing with the R script described in SPARK-11976

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rerngvit/spark SPARK-11976

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/14264.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14264
    
----
commit e1cf3d5994af65a009f9c4de5d001a2e5f8bbcfe
Author: Rerngvit Yanggratoke <re...@combient.com>
Date:   2016-07-19T14:48:15Z

     [SPARK-11976][SPARKR] Support "." character in DataFrame column name
    
        ## What changes were proposed in this pull request?
        - Add support "." character in DataFrame column name
        - Remove R code in "createDataFrame()" that replaces "." with "_"
        - Remove warning suppression in createDataFrame() for SPARK-12034
    
        ## How was this patch tested?
        SparkR unit tests and manual testing with R script described in SPARK-11976

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #14264: [SPARK-11976][SPARKR] Support "." character in Da...

Posted by rerngvit <gi...@git.apache.org>.
Github user rerngvit commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14264#discussion_r71624905
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala ---
    @@ -201,6 +201,8 @@ abstract class LogicalPlan extends QueryPlan[LogicalPlan] with Logging {
           attribute: Attribute): Option[(Attribute, List[String])] = {
         if (!attribute.isGenerated && resolver(attribute.name, nameParts.head)) {
           Option((attribute.withName(nameParts.head), nameParts.tail.toList))
    +    } else if (!attribute.isGenerated && resolver(attribute.name, nameParts.mkString("."))) {
    +      Option((attribute.withName(nameParts.mkString(".")), Nil))
    --- End diff --
    
    @dongjoon-hyun I do not fully understand your question. Could you please elaborate a bit more? What do you mean by "okay for other Spark module"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by rerngvit <gi...@git.apache.org>.
Github user rerngvit commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    @felixcheung: in the recent patch, I removed checking for "." for function colnames() and its test code for the file you indicated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by rerngvit <gi...@git.apache.org>.
Github user rerngvit commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    Since SPARK-11977 didn't get merge and this PR is blocked on that. I decided to close this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62550/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    **[Test build #62612 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62612/consoleFull)** for PR 14264 at commit [`b9000c7`](https://github.com/apache/spark/commit/b9000c71be2b11e16d8749f750282ba8d4a8d248).
     * This patch **fails R style tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by shivaram <gi...@git.apache.org>.
Github user shivaram commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    Jenkins, ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by rerngvit <gi...@git.apache.org>.
Github user rerngvit commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    @sun-rui Thanks. I understand now. I would submit a PR to SPARK-11977 first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    **[Test build #62640 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62640/consoleFull)** for PR 14264 at commit [`60d0145`](https://github.com/apache/spark/commit/60d014501661d1c400675124c99ac7896a184250).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #14264: [SPARK-11976][SPARKR] Support "." character in Da...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14264#discussion_r71467294
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala ---
    @@ -201,6 +201,8 @@ abstract class LogicalPlan extends QueryPlan[LogicalPlan] with Logging {
           attribute: Attribute): Option[(Attribute, List[String])] = {
         if (!attribute.isGenerated && resolver(attribute.name, nameParts.head)) {
           Option((attribute.withName(nameParts.head), nameParts.tail.toList))
    +    } else if (!attribute.isGenerated && resolver(attribute.name, nameParts.mkString("."))) {
    +      Option((attribute.withName(nameParts.mkString(".")), Nil))
    --- End diff --
    
    Hi, I'm just curious. Is it okay for other Spark module?
    > Different from resolveAsTableColumn, this assumes `name` does NOT start with a qualifier.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    **[Test build #62550 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62550/consoleFull)** for PR 14264 at commit [`e1cf3d5`](https://github.com/apache/spark/commit/e1cf3d5994af65a009f9c4de5d001a2e5f8bbcfe).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62640/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by sun-rui <gi...@git.apache.org>.
Github user sun-rui commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    @rerngvit, could you share the background that this PR can fix the issue. I see that https://issues.apache.org/jira/browse/SPARK-11976 is still open. Any other PR in Spark 2.0 make this possible?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by rerngvit <gi...@git.apache.org>.
Github user rerngvit commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    @felixcheung 
    I removed prohibition for "." in the function "colnames()" for SparkR in the recent patch and also its test in the file you mentioned (test_sparkSQL.R L779). Feel free to have a look. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    **[Test build #62640 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62640/consoleFull)** for PR 14264 at commit [`60d0145`](https://github.com/apache/spark/commit/60d014501661d1c400675124c99ac7896a184250).
     * This patch **fails SparkR unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62612/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by rerngvit <gi...@git.apache.org>.
Github user rerngvit commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    @sun-rui
    >  could you share the background that this PR can fix the issue.
    As stated in https://issues.apache.org/jira/browse/SPARK-11976, Spark core is already supporting column name ".".  However, it does not work without the backticks (`). The missing part to make it work is a corresponding logic in the Analyzer layer.
    
    >  I see that https://issues.apache.org/jira/browse/SPARK-11976 is still open.
    I do not fully understand your question. Could you please elaborate a bit more? **This PR** is actually SPARK-11976. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    **[Test build #62550 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62550/consoleFull)** for PR 14264 at commit [`e1cf3d5`](https://github.com/apache/spark/commit/e1cf3d5994af65a009f9c4de5d001a2e5f8bbcfe).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    There's this (and I thought one more, if I recall):
    https://github.com/apache/spark/blob/master/R/pkg/R/DataFrame.R#L349
    
    And its tests in test_sparkSQL.R L779 - I'm surprised these tests pass?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by sun-rui <gi...@git.apache.org>.
Github user sun-rui commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    @rerngvit, sorry, I mean https://issues.apache.org/jira/browse/SPARK-11977. If your PR can enable accesses to columns with "." in their names without backticks, please first submit a PR for SPARK-11977, as the change is for the Spark Core, not SparkR specific. After that PR gets merged, you can then submit a PR for SPARK-11976 which contains SparkR only changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    **[Test build #62612 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62612/consoleFull)** for PR 14264 at commit [`b9000c7`](https://github.com/apache/spark/commit/b9000c71be2b11e16d8749f750282ba8d4a8d248).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #14264: [SPARK-11976][SPARKR] Support "." character in Da...

Posted by rerngvit <gi...@git.apache.org>.
Github user rerngvit closed the pull request at:

    https://github.com/apache/spark/pull/14264


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by sun-rui <gi...@git.apache.org>.
Github user sun-rui commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    @rerngvit, I modifed the title of SPARK-11977 to a narrow scope. You can go for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by rerngvit <gi...@git.apache.org>.
Github user rerngvit commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    @sun-rui Please have a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14264: [SPARK-11976][SPARKR] Support "." character in DataFrame...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14264
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org