You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2017/07/15 00:13:55 UTC
Review Request 60884: Changes for libprocess Message optimization.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60884/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Changes for libprocess Message optimization.
Diffs
-----
src/master/master.cpp 287a5b71bc61949648ac0edff7668f217357a054
Diff: https://reviews.apache.org/r/60884/diff/1/
Testing
-------
Thanks,
Benjamin Hindman
Re: Review Request 60884: Changes for libprocess Message optimization.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60884/#review180613
-----------------------------------------------------------
Bad patch!
Reviews applied: [60884, 60871, 60831, 60830, 60829, 60832, 60826, 60825]
Failed command: python support/apply-reviews.py -n -r 60825
Error:
60825.patch:175: trailing whitespace.
60825.patch:280: trailing whitespace.
// VS2012 doesn't support deleted functions.
60825.patch:332: trailing whitespace.
60825.patch:344: trailing whitespace.
60825.patch:351: trailing whitespace.
error: patch failed: 3rdparty/libprocess/src/process.cpp:116
error: 3rdparty/libprocess/src/process.cpp: patch does not apply
Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/163/console
- Mesos Reviewbot Windows
On July 15, 2017, 12:13 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60884/
> -----------------------------------------------------------
>
> (Updated July 15, 2017, 12:13 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changes for libprocess Message optimization.
>
>
> Diffs
> -----
>
> src/master/master.cpp 287a5b71bc61949648ac0edff7668f217357a054
>
>
> Diff: https://reviews.apache.org/r/60884/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 60884: Changes for libprocess Message optimization.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60884/#review180625
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On July 15, 2017, 12:13 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60884/
> -----------------------------------------------------------
>
> (Updated July 15, 2017, 12:13 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7798
> https://issues.apache.org/jira/browse/MESOS-7798
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changes for libprocess Message optimization.
>
>
> Diffs
> -----
>
> src/master/master.cpp 287a5b71bc61949648ac0edff7668f217357a054
>
>
> Diff: https://reviews.apache.org/r/60884/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>