You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/02/10 11:32:23 UTC
[GitHub] [incubator-tubemq] gosonzhang opened a new pull request #19:
[TUBEMQ-12]Change to use Apache License V2 and enable RAT check
gosonzhang opened a new pull request #19: [TUBEMQ-12]Change to use Apache License V2 and enable RAT check
URL: https://github.com/apache/incubator-tubemq/pull/19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] gosonzhang commented on issue #19:
[TUBEMQ-12]Change to use Apache License V2 and enable RAT check
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on issue #19: [TUBEMQ-12]Change to use Apache License V2 and enable RAT check
URL: https://github.com/apache/incubator-tubemq/pull/19#issuecomment-584158866
After enable the RAT check, I found that the PR compilation time has been extended a lot, so I reverted the modification of the travis-ci script.
Everyone can enable CAT check by adding "apache-rat: check" to the mvn command line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] gosonzhang commented on issue #19:
[TUBEMQ-12]Change to use Apache License V2 and enable RAT check
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on issue #19: [TUBEMQ-12]Change to use Apache License V2 and enable RAT check
URL: https://github.com/apache/incubator-tubemq/pull/19#issuecomment-584088870
This PR only changed LICENSE of files, the " enable RAT check" is copied from Jira name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] gosonzhang commented on issue #19:
[TUBEMQ-12]Change to use Apache License V2 and enable RAT check
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on issue #19: [TUBEMQ-12]Change to use Apache License V2 and enable RAT check
URL: https://github.com/apache/incubator-tubemq/pull/19#issuecomment-584143270
I checked the pom.xml, the rat check already existed, but not enabled in the CI script, but after the function was enabled, the entire compilation time took more than 20 minutes and it is not over yet.
It is better to enable RAT check locally before submitting pr or before incorporating the code, NOT in CI script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] yiheng commented on issue #19: [TUBEMQ-12]Change
to use Apache License V2 and enable RAT check
Posted by GitBox <gi...@apache.org>.
yiheng commented on issue #19: [TUBEMQ-12]Change to use Apache License V2 and enable RAT check
URL: https://github.com/apache/incubator-tubemq/pull/19#issuecomment-584087636
can you highlight where do we enable RAT check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] lizhiboo merged pull request #19:
[TUBEMQ-12]Change to use Apache License V2
Posted by GitBox <gi...@apache.org>.
lizhiboo merged pull request #19: [TUBEMQ-12]Change to use Apache License V2
URL: https://github.com/apache/incubator-tubemq/pull/19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] yiheng commented on issue #19: [TUBEMQ-12]Change
to use Apache License V2 and enable RAT check
Posted by GitBox <gi...@apache.org>.
yiheng commented on issue #19: [TUBEMQ-12]Change to use Apache License V2 and enable RAT check
URL: https://github.com/apache/incubator-tubemq/pull/19#issuecomment-584095239
I suggest split the JIRA into small sub-tasks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] yiheng commented on issue #19: [TUBEMQ-12]Change
to use Apache License V2 and enable RAT check
Posted by GitBox <gi...@apache.org>.
yiheng commented on issue #19: [TUBEMQ-12]Change to use Apache License V2 and enable RAT check
URL: https://github.com/apache/incubator-tubemq/pull/19#issuecomment-584096458
IMHO, the change is not reviewable without check in the enable RAT check change. No one can review such changes. Instead, if we enable the RAT check. The change can be verified automatically by the travis build job. Then we just need to review the RAT enable check change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] yiheng edited a comment on issue #19:
[TUBEMQ-12]Change to use Apache License V2 and enable RAT check
Posted by GitBox <gi...@apache.org>.
yiheng edited a comment on issue #19: [TUBEMQ-12]Change to use Apache License V2 and enable RAT check
URL: https://github.com/apache/incubator-tubemq/pull/19#issuecomment-584087636
can you highlight where do we enable RAT check? This change touches a lot of files. It's better to leave a comment on the change where enables the RAT check. (I try to search but not found)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] guangxuCheng commented on issue #19:
[TUBEMQ-12]Change to use Apache License V2 and enable RAT check
Posted by GitBox <gi...@apache.org>.
guangxuCheng commented on issue #19: [TUBEMQ-12]Change to use Apache License V2 and enable RAT check
URL: https://github.com/apache/incubator-tubemq/pull/19#issuecomment-584098021
Agree with what @yiheng said.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] yiheng removed a comment on issue #19:
[TUBEMQ-12]Change to use Apache License V2 and enable RAT check
Posted by GitBox <gi...@apache.org>.
yiheng removed a comment on issue #19: [TUBEMQ-12]Change to use Apache License V2 and enable RAT check
URL: https://github.com/apache/incubator-tubemq/pull/19#issuecomment-584095239
I suggest split the JIRA into small sub-tasks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tubemq] gosonzhang edited a comment on issue #19:
[TUBEMQ-12]Change to use Apache License V2 and enable RAT check
Posted by GitBox <gi...@apache.org>.
gosonzhang edited a comment on issue #19: [TUBEMQ-12]Change to use Apache License V2 and enable RAT check
URL: https://github.com/apache/incubator-tubemq/pull/19#issuecomment-584088870
This PR only changed LICENSE of files, the " enable RAT check" is copied from Jira name.
This PR only changed the permissions of the files. After the completion, I found that nearly 400 files were modified. In order to avoid mutual influence, I will propose PR amendments one by one according to the topic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services