You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org> on 2006/01/19 11:19:42 UTC
[jira] Created: (MYFACES-1042) AddResource should use the current
character encoding
AddResource should use the current character encoding
-----------------------------------------------------
Key: MYFACES-1042
URL: http://issues.apache.org/jira/browse/MYFACES-1042
Project: MyFaces
Type: Bug
Components: General
Versions: Nightly
Reporter: Mario Ivankovits
Priority: Blocker
In AddResource.writeWithFullHeader the current character encoding wont be used when instantiating the ResponseWriter.
This will encode the whole page even if the page is already in UTF-8 - where no further encoding should be done.
I maked it as blocker as this will break html-embedded-javascripts. All non-ascii characters were encoded and e.g. when alert() them the browser wont decode it.
But feel free to adjust the priority.
Attached you will find a patch which will take the response.getCharacterEncoding() - and the adjusted Test-Case.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-1042) AddResource should use the current
character encoding
Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1042?page=all ]
Martin Marinschek closed MYFACES-1042:
--------------------------------------
Fix Version: Nightly
Resolution: Fixed
Assign To: Martin Marinschek
Thanks to Mario Ivankovits for this fix.
> AddResource should use the current character encoding
> -----------------------------------------------------
>
> Key: MYFACES-1042
> URL: http://issues.apache.org/jira/browse/MYFACES-1042
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Reporter: Mario Ivankovits
> Assignee: Martin Marinschek
> Priority: Blocker
> Fix For: Nightly
> Attachments: add_resource_encoding.diff
>
> In AddResource.writeWithFullHeader the current character encoding wont be used when instantiating the ResponseWriter.
> This will encode the whole page even if the page is already in UTF-8 - where no further encoding should be done.
> I maked it as blocker as this will break html-embedded-javascripts. All non-ascii characters were encoded and e.g. when alert() them the browser wont decode it.
> But feel free to adjust the priority.
> Attached you will find a patch which will take the response.getCharacterEncoding() - and the adjusted Test-Case.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-1042) AddResource should use the current
character encoding
Posted by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1042?page=all ]
Mario Ivankovits updated MYFACES-1042:
--------------------------------------
Attachment: add_resource_encoding.diff
> AddResource should use the current character encoding
> -----------------------------------------------------
>
> Key: MYFACES-1042
> URL: http://issues.apache.org/jira/browse/MYFACES-1042
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Reporter: Mario Ivankovits
> Priority: Blocker
> Attachments: add_resource_encoding.diff
>
> In AddResource.writeWithFullHeader the current character encoding wont be used when instantiating the ResponseWriter.
> This will encode the whole page even if the page is already in UTF-8 - where no further encoding should be done.
> I maked it as blocker as this will break html-embedded-javascripts. All non-ascii characters were encoded and e.g. when alert() them the browser wont decode it.
> But feel free to adjust the priority.
> Attached you will find a patch which will take the response.getCharacterEncoding() - and the adjusted Test-Case.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira