You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "ahmedriza (via GitHub)" <gi...@apache.org> on 2023/02/17 15:25:07 UTC
[GitHub] [arrow-datafusion] ahmedriza opened a new pull request, #5324: Add missing protobuf serialisation functionality GetIndexedFieldExpr.
ahmedriza opened a new pull request, #5324:
URL: https://github.com/apache/arrow-datafusion/pull/5324
This is required in order for `ballista` to serialise the indexing expressions for nested lists. Otherwise, `ballista` cannot execute any SQL that contains indexing expressions.
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/arrow-datafusion/issues/5323
# Rationale for this change
Add missing protobuf serialisation for `GetIndexedFieldExpr` that is required when running queries that index nested structures.
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
Add protobuf serialisation for `GetIndexedFieldExpr` and a unit test.
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
Yes
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
No
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5324: Add missing protobuf serialisation functionality GetIndexedFieldExpr.
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5324:
URL: https://github.com/apache/arrow-datafusion/pull/5324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5324: Add missing protobuf serialisation functionality GetIndexedFieldExpr.
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5324:
URL: https://github.com/apache/arrow-datafusion/pull/5324#issuecomment-1435122109
I merged this soon as I don't think it is controversial. I am happy to make changes or back it out if any maintainer feels differently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5324: Add missing protobuf serialisation functionality GetIndexedFieldExpr.
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5324:
URL: https://github.com/apache/arrow-datafusion/pull/5324#issuecomment-1435130192
Benchmark runs are scheduled for baseline = d6d9c6f2e0c3100efade43d1342d8c9522919e1f and contender = c5108aef4d2660cce950976af14d33444f27075e. c5108aef4d2660cce950976af14d33444f27075e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/654651067dbd4306a7a0fa45fcd17fde...93b7c89e668d4880b647b452ec940fee/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/46c3a35bf6de4111aa6f0507ecb143f1...e1b0c784461843378a5a29295280a438/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1061996fe9c64591b0eed1e83cbacff5...d8506e8a8bd8468693e67468ec65d7d0/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9952e73aabc84864b7eebebf8fa6fa3d...81e07dd6210b46fc8fc056bf2d1a95be/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org