You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by pascal-bach <gi...@git.apache.org> on 2014/06/10 15:19:30 UTC

[GitHub] thrift pull request: Thrift 2571

GitHub user pascal-bach opened a pull request:

    https://github.com/apache/thrift/pull/137

    Thrift 2571

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/siemens/thrift THRIFT-2571

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #137
    
----
commit 6eb015aa555ba120c156e21a8a9ecff15589c7b0
Author: Pascal Bach <pa...@siemens.com>
Date:   2014-04-17T14:19:07Z

    Add CMake file for the thrift compiler

commit 42be4e818ada259080811a87fb239fa81222f581
Author: Pascal Bach <pa...@siemens.com>
Date:   2014-04-23T16:19:06Z

    Get thrift version from configure.ac for CMake build

commit 569863a1385c38eb937662aa655db1c3fb0819fe
Author: Pascal Bach <pa...@siemens.com>
Date:   2014-06-10T11:15:40Z

    Allow cross build for windows using mingw32
    
    - Build the compiler using CMake for:
      - Linux native gcc
      - Windows using mingw32

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2571 Simplify cross compilation using ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/137


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2571 Simplify cross compilation using ...

Posted by henrique <gi...@git.apache.org>.

Github user henrique commented on the pull request:

    https://github.com/apache/thrift/pull/137#issuecomment-45619994
  
    Hi Pascal,
    Thanks a lot for the request. This is a great step towards simplifying cross platform support as you have already said.
    Would you document the indicated building steps in the root or the compiler Readme.md as you have already done in the ticket? Perhaps we can mark it as experimental or alternative as it still only covers the Thrift compiler. 
    
    Cheers!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---