You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/06 19:56:00 UTC
[jira] [Commented] (METRON-1345) Update EC2 README for custom
Ansible tags
[ https://issues.apache.org/jira/browse/METRON-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280796#comment-16280796 ]
ASF GitHub Bot commented on METRON-1345:
----------------------------------------
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/859
METRON-1345: Update EC2 README for custom Ansible tags
https://issues.apache.org/jira/browse/METRON-1345
Simple improvement/correction to the EC2 README. This runs the command with the appropriate environment info and skip-tags enabled via the run.sh script instead of through ansible-playbook directly, which misses some things.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/metron ec2-doc-change
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/859.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #859
----
commit f95a4173bd71c5e8380c3e0708cb4ab7d8ddee97
Author: Michael Miklavcic <mi...@gmail.com>
Date: 2017-12-06T19:52:39Z
METRON-1345: Update EC2 README for custom Ansible tags
----
> Update EC2 README for custom Ansible tags
> -----------------------------------------
>
> Key: METRON-1345
> URL: https://issues.apache.org/jira/browse/METRON-1345
> Project: Metron
> Issue Type: Improvement
> Reporter: Michael Miklavcic
> Assignee: Michael Miklavcic
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)