You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "dk2k (via GitHub)" <gi...@apache.org> on 2023/04/08 19:12:51 UTC
[GitHub] [camel] dk2k opened a new pull request, #9831: Fixed results of inspection "redundant local variable" for tooling
dk2k opened a new pull request, #9831:
URL: https://github.com/apache/camel/pull/9831
Fixed results of inspection "redundant local variable". Inlining of variables is the solution. PR for tooling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #9831: Fixed results of inspection "redundant local variable" for tooling
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #9831:
URL: https://github.com/apache/camel/pull/9831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a diff in pull request #9831: Fixed results of inspection "redundant local variable" for tooling
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #9831:
URL: https://github.com/apache/camel/pull/9831#discussion_r1161216154
##########
tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/EndpointSchemaGeneratorMojo.java:
##########
@@ -1051,9 +1051,8 @@ protected void findComponentClassProperties(
.filter(opt -> name.equals(opt.getName())).findAny();
if (prev.isPresent()) {
String prv = prev.get().getJavaType();
- String cur = fieldTypeName;
Review Comment:
using `cur` for current makes the code easier to read, so lets keep the code as-is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9831: Fixed results of inspection "redundant local variable" for tooling
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9831:
URL: https://github.com/apache/camel/pull/9831#issuecomment-1501075353
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org