[GitHub] spark pull request #18481: [SPARK-20889][SparkR] Grouped documentation for W...

[felixcheung <gi...@git.apache.org>]

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18481#discussion_r125154492
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -2871,10 +2874,10 @@ setMethod("ifelse",
     
     #' @details
     #' \code{cume_dist}: Returns the cumulative distribution of values within a window partition,
    -#' i.e. the fraction of rows that are below the current row.
    -#' N = total number of rows in the partition
    -#' cume_dist(x) = number of values before (and including) x / N
    +#' i.e. the fraction of rows that are below the current row:
    +#' number of values before (and including) x / total number of rows in the partition.
    --- End diff --
    
    with that many words it seems the fact this is a formula is lost. how about this like the other formula
    ```
    
    (number of values before and including x) / (total number of rows in the partition)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org