[GitHub] [incubator-pinot] jackjlli opened a new pull request #4688: Modify the logic of getting tenant names APIs

[GitBox <gi...@apache.org>]

jackjlli opened a new pull request #4688: Modify the logic of getting tenant names APIs
URL: https://github.com/apache/incubator-pinot/pull/4688
 
 
   This PR modifies the logic of getting tenant name APIs.
   
   The previous code firstly get the list of instance names from `/INSTANCES` ZNode and then get the instance configs one by one from `/CONFIG/PARTICIPANT/INSTANCES` ZNode. Whereas these two ZNode may be inconsistent. 
   That's why we sometimes encounter flaky NPE when calling these APIs.
   
   Sample exception:
   ```
   java.lang.NullPointerException
   	at org.apache.pinot.controller.helix.core.PinotHelixResourceManager.getAllBrokerTenantNames(PinotHelixResourceManager.java:808)
   	at org.apache.pinot.controller.helix.core.PinotHelixResourceManagerTest.testRetrieveTenantNames(PinotHelixResourceManagerTest.java:278)
   	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   	at java.lang.reflect.Method.invoke(Method.java:498)
   	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:108)
   	at org.testng.internal.Invoker.invokeMethod(Invoker.java:661)
   	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:869)
   	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1193)
   	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:126)
   	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:109)
   	at org.testng.TestRunner.privateRun(TestRunner.java:744)
   	at org.testng.TestRunner.run(TestRunner.java:602)
   	at org.testng.SuiteRunner.runTest(SuiteRunner.java:380)
   	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:375)
   	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:340)
   	at org.testng.SuiteRunner.run(SuiteRunner.java:289)
   	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
   	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
   	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1301)
   	at org.testng.TestNG.runSuitesLocally(TestNG.java:1226)
   	at org.testng.TestNG.runSuites(TestNG.java:1144)
   	at org.testng.TestNG.run(TestNG.java:1115)
   	at org.testng.IDEARemoteTestNG.run(IDEARemoteTestNG.java:73)
   	at org.testng.RemoteTestNGStarter.main(RemoteTestNGStarter.java:123)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org